Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

[Richard Henderson <rth@twiddle.net>]

On 01/15/2015 07:01 AM, Peter Maydell wrote:
> I was looking at our confusing mess of memory accessor functions,
> and I realised that partly it was confusing because we have a
> bunch of unnecessary junk lurking in there :-) This series
> attempts to clean things up by removing things we weren't using
> at all or were only using by mistake in a few places:
> 
>  * ldul_*: not used
>  * ld* (ldl, etc): hardly used
>  * ld*_kernel: not used
>  * ld*_raw: hardly used
>  * cpu_{ld,st}{fq,fl}: not used
> 
> The dull parts of this series are removing the unused macros
> and fixing uses of the hardly-used macros so those can be
> deleted too. This series also switches to using inline functions
> rather than macros for the user-only cpu_ld/st* accessors, bringing
> them into line with the softmmu configs. This has the nice
> side effect of letting us get rid of the _raw accessor macros too.
> I've also thrown in a commit which cleans up the doc comments.
> 
> Peter Maydell (15):
>   cpu_ldst.h: Remove unused ldul_ macros
>   monitor.c: Use ld*_p() instead of ld*_raw()
>   target-sparc: Don't use {ld,st}*_raw functions
>   linux-user/elfload.c: Don't use _raw accessor functions
>   bsd-user/elfload.c: Don't use ldl() or ldq_raw()
>   linux-user/vm86.c: Use cpu_ldl_data &c rather than plain ldl &c
>   linux-user/main.c (m68k): Use get_user_u16 rather than lduw in
>     cpu_loop
>   target-mips: Don't use _raw load/store accessors
>   cpu_ldst.h: Drop unused ld/st*_kernel defines
>   cpu_ldst.h: Remove unused very short ld*/st* defines
>   cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors
>   cpu_ldst_template.h: Use ld*_p directly rather than via ld*_raw macros
>   cpu_ldst.h: Drop unused _raw macros, saddr() and laddr()
>   cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors
>   cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st
>     accessors

Reviewed-by: Richard Henderson <rth@twiddle.net>

Nice cleanup.

r~