* [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
@ 2014-09-26 10:43 ` Joonyoung Shim
0 siblings, 0 replies; 6+ messages in thread
From: Joonyoung Shim @ 2014-09-26 10:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: cw00.choi, kgene.kim, m.szyprowski, linux-arm-kernel, tomasz.figa
The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
A7, it can't detect right UART physical address only the part number of
CP15. It's possible to solve as checking Cluster ID additionally.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
arch/arm/include/debug/exynos.S | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
index b17fdb7..60bf3c2 100644
--- a/arch/arm/include/debug/exynos.S
+++ b/arch/arm/include/debug/exynos.S
@@ -24,7 +24,11 @@
mrc p15, 0, \tmp, c0, c0, 0
and \tmp, \tmp, #0xf0
teq \tmp, #0xf0 @@ A15
- ldreq \rp, =EXYNOS5_PA_UART
+ beq 100f
+ mrc p15, 0, \tmp, c0, c0, 5
+ and \tmp, \tmp, #0xf00
+ teq \tmp, #0x100 @@ A15 + A7 but boot to A7
+100: ldreq \rp, =EXYNOS5_PA_UART
movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
ldr \rv, =S3C_VA_UART
#if CONFIG_DEBUG_S3C_UART != 0
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
@ 2014-09-26 10:43 ` Joonyoung Shim
0 siblings, 0 replies; 6+ messages in thread
From: Joonyoung Shim @ 2014-09-26 10:43 UTC (permalink / raw)
To: linux-arm-kernel
The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
A7, it can't detect right UART physical address only the part number of
CP15. It's possible to solve as checking Cluster ID additionally.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
arch/arm/include/debug/exynos.S | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
index b17fdb7..60bf3c2 100644
--- a/arch/arm/include/debug/exynos.S
+++ b/arch/arm/include/debug/exynos.S
@@ -24,7 +24,11 @@
mrc p15, 0, \tmp, c0, c0, 0
and \tmp, \tmp, #0xf0
teq \tmp, #0xf0 @@ A15
- ldreq \rp, =EXYNOS5_PA_UART
+ beq 100f
+ mrc p15, 0, \tmp, c0, c0, 5
+ and \tmp, \tmp, #0xf00
+ teq \tmp, #0x100 @@ A15 + A7 but boot to A7
+100: ldreq \rp, =EXYNOS5_PA_UART
movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
ldr \rv, =S3C_VA_UART
#if CONFIG_DEBUG_S3C_UART != 0
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
2014-09-26 10:43 ` Joonyoung Shim
@ 2015-01-19 6:55 ` Joonyoung Shim
-1 siblings, 0 replies; 6+ messages in thread
From: Joonyoung Shim @ 2015-01-19 6:55 UTC (permalink / raw)
To: linux-samsung-soc
Cc: cw00.choi, kgene.kim, tomasz.figa, linux-arm-kernel, m.szyprowski,
kgene
Hi kukjin,
On 09/26/2014 07:43 PM, Joonyoung Shim wrote:
> The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
> A7, it can't detect right UART physical address only the part number of
> CP15. It's possible to solve as checking Cluster ID additionally.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> arch/arm/include/debug/exynos.S | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
> index b17fdb7..60bf3c2 100644
> --- a/arch/arm/include/debug/exynos.S
> +++ b/arch/arm/include/debug/exynos.S
> @@ -24,7 +24,11 @@
> mrc p15, 0, \tmp, c0, c0, 0
> and \tmp, \tmp, #0xf0
> teq \tmp, #0xf0 @@ A15
> - ldreq \rp, =EXYNOS5_PA_UART
> + beq 100f
> + mrc p15, 0, \tmp, c0, c0, 5
> + and \tmp, \tmp, #0xf00
> + teq \tmp, #0x100 @@ A15 + A7 but boot to A7
> +100: ldreq \rp, =EXYNOS5_PA_UART
> movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
> ldr \rv, =S3C_VA_UART
> #if CONFIG_DEBUG_S3C_UART != 0
>
Any comments?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
@ 2015-01-19 6:55 ` Joonyoung Shim
0 siblings, 0 replies; 6+ messages in thread
From: Joonyoung Shim @ 2015-01-19 6:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi kukjin,
On 09/26/2014 07:43 PM, Joonyoung Shim wrote:
> The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
> A7, it can't detect right UART physical address only the part number of
> CP15. It's possible to solve as checking Cluster ID additionally.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> arch/arm/include/debug/exynos.S | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
> index b17fdb7..60bf3c2 100644
> --- a/arch/arm/include/debug/exynos.S
> +++ b/arch/arm/include/debug/exynos.S
> @@ -24,7 +24,11 @@
> mrc p15, 0, \tmp, c0, c0, 0
> and \tmp, \tmp, #0xf0
> teq \tmp, #0xf0 @@ A15
> - ldreq \rp, =EXYNOS5_PA_UART
> + beq 100f
> + mrc p15, 0, \tmp, c0, c0, 5
> + and \tmp, \tmp, #0xf00
> + teq \tmp, #0x100 @@ A15 + A7 but boot to A7
> +100: ldreq \rp, =EXYNOS5_PA_UART
> movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
> ldr \rv, =S3C_VA_UART
> #if CONFIG_DEBUG_S3C_UART != 0
>
Any comments?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
2015-01-19 6:55 ` Joonyoung Shim
@ 2016-06-22 6:24 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-22 6:24 UTC (permalink / raw)
To: Joonyoung Shim
Cc: linux-samsung-soc, Tomasz Figa, Chanwoo Choi, kgene.kim, kgene,
linux-arm-kernel, Marek Szyprowski
On Mon, Jan 19, 2015 at 7:55 AM, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> Hi kukjin,
>
> On 09/26/2014 07:43 PM, Joonyoung Shim wrote:
>> The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
>> A7, it can't detect right UART physical address only the part number of
>> CP15. It's possible to solve as checking Cluster ID additionally.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>> arch/arm/include/debug/exynos.S | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
This is an old patch... but still valid and needed on Odroid XU
family. Tested by Marek Szyprowski.
Applied, thanks!
BR,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL
@ 2016-06-22 6:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-22 6:24 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 19, 2015 at 7:55 AM, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> Hi kukjin,
>
> On 09/26/2014 07:43 PM, Joonyoung Shim wrote:
>> The exynos5 SoCs using A15+A7 can boot to A15 or A7. If it boots using
>> A7, it can't detect right UART physical address only the part number of
>> CP15. It's possible to solve as checking Cluster ID additionally.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>> arch/arm/include/debug/exynos.S | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
This is an old patch... but still valid and needed on Odroid XU
family. Tested by Marek Szyprowski.
Applied, thanks!
BR,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-22 6:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-26 10:43 [PATCH] ARM: exynos: fix UART address selection for DEBUG_LL Joonyoung Shim
2014-09-26 10:43 ` Joonyoung Shim
2015-01-19 6:55 ` Joonyoung Shim
2015-01-19 6:55 ` Joonyoung Shim
2016-06-22 6:24 ` Krzysztof Kozlowski
2016-06-22 6:24 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.