All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: oleksandr.dmytryshyn@globallogic.com,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Guidelines for new PV protocol submission
Date: Tue, 20 Jan 2015 13:47:38 +0100	[thread overview]
Message-ID: <54BE4E6A.8010102@citrix.com> (raw)

Hello,

I should probably have done this earlier because I've been aware of this
issue for a long time (since I've started dealing with the PV blk protocol).

The current way to describe PV protocols in Xen is very inefficient
IMHO. Using C structs as "the description" of a binary protocol seems
very wrong, specially taking into account that different ABIs can
generate different layouts for the same C struct. This is for example a
problem in the PV blk protocol, since the binary layout of the
structures change depending on the bitness.

In order to avoid this, I would like to request that any new PV protocol
that's added to Xen be described in binary terms, just like it's
normally done with other protocols. As a reference see for example the
following section from the TCP RFC:

http://tools.ietf.org/html/rfc793#page-15

I think this is both more easy to understand and removes the bitness
problem of using C structs.

Then each user of this protocol could define it's own set of structures
that would map to the binary layout, which should be almost trivial.
There would be no problem with using __packed or similar gcc'isms as
each implementation could choose the more convenient way to represent
this layout internally.

Roger.

             reply	other threads:[~2015-01-20 12:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 12:47 Roger Pau Monné [this message]
2015-01-20 13:20 ` Guidelines for new PV protocol submission David Vrabel
2015-01-20 13:39   ` Andrew Cooper
2015-01-20 13:48     ` Jan Beulich
2015-01-20 14:00       ` Andrew Cooper
2015-01-20 16:32         ` Jan Beulich
2015-01-20 14:21       ` Ian Jackson
2015-01-20 16:28         ` Ian Campbell
2015-01-20 13:46 ` Jan Beulich
2015-02-05 10:42 ` Ian Campbell
2015-02-09 11:01   ` Roger Pau Monné
2015-02-09 11:11     ` Ian Campbell
2015-02-09 11:59 ` Vitaly Chernooky
2015-02-09 13:15   ` Ian Campbell
2015-02-09 13:45     ` Vitaly Chernooky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BE4E6A.8010102@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=oleksandr.dmytryshyn@globallogic.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.