From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-davinci: Remove driver CDCE949
Date: Tue, 20 Jan 2015 19:29:24 +0530 [thread overview]
Message-ID: <54BE5F3C.50907@ti.com> (raw)
In-Reply-To: <54BC8F2B.10509@ti.com>
On Monday 19 January 2015 10:29 AM, Sekhar Nori wrote:
> Hi,
>
> On Monday 19 January 2015 05:07 AM, Rickard Strandqvist wrote:
>> Remove driver CDCE949 because it is not used anywhere.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
>
>> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
>> index ae129bc..8be5aef 100644
>> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
>> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
>> @@ -45,7 +45,6 @@
>> #include <mach/irqs.h>
>> #include <mach/serial.h>
>> #include <mach/clock.h>
>> -#include <mach/cdce949.h>
>>
>> #include "davinci.h"
>> #include "clock.h"
>> @@ -399,9 +398,6 @@ static struct i2c_board_info __initdata i2c_info[] = {
>> {
>> I2C_BOARD_INFO("cpld_video", 0x3b),
>> },
>> - {
>> - I2C_BOARD_INFO("cdce949", 0x6c),
>> - },
>> };
>
> There is cdce_clk_init() and associated data structures that also need
> to be removed.
In the interest of time, I made this change myself.
I will be merging the attached patch with this one.
Thanks,
Sekhar
---8<---
diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index 8be5aef3aca9..846a84ddc28e 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -711,31 +711,6 @@ static void __init evm_init_i2c(void)
evm_init_video();
}
-#define CDCE949_XIN_RATE 27000000
-
-/* CDCE949 support - "lpsc" field is overridden to work as clock number */
-static struct clk cdce_clk_in = {
- .name = "cdce_xin",
- .rate = CDCE949_XIN_RATE,
-};
-
-static struct clk_lookup cdce_clks[] = {
- CLK(NULL, "xin", &cdce_clk_in),
- CLK(NULL, NULL, NULL),
-};
-
-static void __init cdce_clk_init(void)
-{
- struct clk_lookup *c;
- struct clk *clk;
-
- for (c = cdce_clks; c->clk; c++) {
- clk = c->clk;
- clkdev_add(c);
- clk_register(clk);
- }
-}
-
#define DM6467T_EVM_REF_FREQ 33000000
static void __init davinci_map_io(void)
@@ -744,8 +719,6 @@ static void __init davinci_map_io(void)
if (machine_is_davinci_dm6467tevm())
davinci_set_refclk_rate(DM6467T_EVM_REF_FREQ);
-
- cdce_clk_init();
}
#define DM646X_EVM_PHY_ID "davinci_mdio-0:01"
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Kevin Hilman <khilman@deeprootsystems.com>
Cc: Russell King <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: mach-davinci: Remove driver CDCE949
Date: Tue, 20 Jan 2015 19:29:24 +0530 [thread overview]
Message-ID: <54BE5F3C.50907@ti.com> (raw)
In-Reply-To: <54BC8F2B.10509@ti.com>
On Monday 19 January 2015 10:29 AM, Sekhar Nori wrote:
> Hi,
>
> On Monday 19 January 2015 05:07 AM, Rickard Strandqvist wrote:
>> Remove driver CDCE949 because it is not used anywhere.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
>
>> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
>> index ae129bc..8be5aef 100644
>> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
>> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
>> @@ -45,7 +45,6 @@
>> #include <mach/irqs.h>
>> #include <mach/serial.h>
>> #include <mach/clock.h>
>> -#include <mach/cdce949.h>
>>
>> #include "davinci.h"
>> #include "clock.h"
>> @@ -399,9 +398,6 @@ static struct i2c_board_info __initdata i2c_info[] = {
>> {
>> I2C_BOARD_INFO("cpld_video", 0x3b),
>> },
>> - {
>> - I2C_BOARD_INFO("cdce949", 0x6c),
>> - },
>> };
>
> There is cdce_clk_init() and associated data structures that also need
> to be removed.
In the interest of time, I made this change myself.
I will be merging the attached patch with this one.
Thanks,
Sekhar
---8<---
diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index 8be5aef3aca9..846a84ddc28e 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -711,31 +711,6 @@ static void __init evm_init_i2c(void)
evm_init_video();
}
-#define CDCE949_XIN_RATE 27000000
-
-/* CDCE949 support - "lpsc" field is overridden to work as clock number */
-static struct clk cdce_clk_in = {
- .name = "cdce_xin",
- .rate = CDCE949_XIN_RATE,
-};
-
-static struct clk_lookup cdce_clks[] = {
- CLK(NULL, "xin", &cdce_clk_in),
- CLK(NULL, NULL, NULL),
-};
-
-static void __init cdce_clk_init(void)
-{
- struct clk_lookup *c;
- struct clk *clk;
-
- for (c = cdce_clks; c->clk; c++) {
- clk = c->clk;
- clkdev_add(c);
- clk_register(clk);
- }
-}
-
#define DM6467T_EVM_REF_FREQ 33000000
static void __init davinci_map_io(void)
@@ -744,8 +719,6 @@ static void __init davinci_map_io(void)
if (machine_is_davinci_dm6467tevm())
davinci_set_refclk_rate(DM6467T_EVM_REF_FREQ);
-
- cdce_clk_init();
}
#define DM646X_EVM_PHY_ID "davinci_mdio-0:01"
next prev parent reply other threads:[~2015-01-20 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 23:37 [PATCH] ARM: mach-davinci: Remove driver CDCE949 Rickard Strandqvist
2015-01-18 23:37 ` Rickard Strandqvist
2015-01-19 4:59 ` Sekhar Nori
2015-01-19 4:59 ` Sekhar Nori
2015-01-20 13:59 ` Sekhar Nori [this message]
2015-01-20 13:59 ` Sekhar Nori
2015-01-20 18:35 ` Rickard Strandqvist
2015-01-20 18:35 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BE5F3C.50907@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.