Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

[Jim Fehlig <jfehlig@suse.com>]

Ian Campbell wrote:
> On Mon, 2015-01-19 at 09:37 +0000, Ian Campbell wrote:
>   
>> On Mon, 2015-01-19 at 04:48 +0000, xen.org wrote:
>>     
>>> branch xen-unstable
>>> xen branch xen-unstable
>>> job build-armhf-libvirt
>>> test libvirt-build
>>>
>>> Tree: libvirt git://libvirt.org/libvirt.git
>>> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
>>> Tree: xen git://xenbits.xen.org/xen.git
>>>
>>> *** Found and reproduced problem changeset ***
>>>
>>>   Bug is in tree:  libvirt git://libvirt.org/libvirt.git
>>>   Bug introduced:  2c78051a14acfb7aba078d569b1632dfe0ca0853
>>>   Bug not present: 7ad117b2e33039737126ce9df7a267a6f939988d
>>>
>>>
>>>   commit 2c78051a14acfb7aba078d569b1632dfe0ca0853
>>>   Author: Kiarie Kahurani <davidkiarie4@gmail.com>
>>>   Date:   Thu Sep 11 07:10:33 2014 +0300
>>>   
>>>       src/xenconfig: Xen-xl parser
>>>       
>> This has since been reverted and done again differently, so nothing to
>> worry about I think.
>>     
>
> That said the latest failure is 
> http://www.chiark.greenend.org.uk/~xensrcts/logs/33553/build-amd64-libvirt/5.ts-libvirt-build.log
>           CC     virdbustest-testutils.o
>           CC     virsystemdtest-virsystemdtest.o
>           CC     virsystemdtest-testutils.o
>           CC     virdrivermoduletest.o
>           CCLD   xlconfigtest
>           CC     qemuxml2argvtest.o
>         /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o: In function `_start':
>         (.text+0x20): undefined reference to `main'
>         collect2: error: ld returned 1 exit status
> (from http://www.chiark.greenend.org.uk/~xensrcts/logs/33553/ )
>
> The bisector is working on it, partial result at:
> http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.libvirt.build-amd64-libvirt.libvirt-build.html
>   

I noticed the bisector finished and flagged this commit

  commit 4ed5fb91934cbad53cc4128030869f4b46e0811d
  Author: Kiarie Kahurani <davidkiarie4@gmail.com>
  Date: Mon Dec 15 21:30:05 2014 -0700

       tests: Tests for the xen-xl parser

       Add disk and spice config tests for the xen_xl config parser

       Signed-off-by: Kiarie Kahurani <davidkiarie4@gmail.com>
       Signed-off-by: Jim Fehlig <jfehlig@suse.com>

I've sent a patch to fix the issue

https://www.redhat.com/archives/libvir-list/2015-January/msg00709.html

Sadly, I never tested the original series --without-xen. With the above
patch, I've ensured 'make distcheck' passes with the following
configurations

--without-xen --with-libxl
--with-xen --without-libxl
--without-xen --without-libxl
--with-xen --with-libxl

Regards,
Jim