Re: [Qemu-devel] [PATCH v5 1/5] pc: acpi-build: cleanup AcpiPmInfo initialization

[Marcel Apfelbaum <marcel@redhat.com>]

On 01/21/2015 11:09 AM, Igor Mammedov wrote:
> zero initialize AcpiPmInfo struct to reduce code bloat
> a little bit.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
> ---
>   hw/i386/acpi-build.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 77a124e..4c0536f 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
>       Object *obj = NULL;
>       QObject *o;
>
> +    memset(pm, 0, sizeof(*pm));
> +
>       if (piix) {
>           obj = piix;
>       }
> @@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
>       if (o) {
>           pm->s3_disabled = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s3_disabled = false;
>       }
>       qobject_decref(o);
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
>       if (o) {
>           pm->s4_disabled = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s4_disabled = false;
>       }
>       qobject_decref(o);
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
>       if (o) {
>           pm->s4_val = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s4_val = false;
>       }
>       qobject_decref(o);
>
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>