From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Inha Song <ideal.song@samsung.com>
Cc: alsa-devel@alsa-project.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, kgene@kernel.org, sbkim73@samsung.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.de, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2
Date: Wed, 21 Jan 2015 17:23:21 +0100 [thread overview]
Message-ID: <54BFD279.7080604@samsung.com> (raw)
In-Reply-To: <1421660902-29679-4-git-send-email-ideal.song@samsung.com>
Hi,
On 19/01/15 10:48, Inha Song wrote:
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> + sound {
> + compatible = "samsung,trats2-audio";
> + assigned-clocks = <&pmu_system_controller 0>;
> + assigned-clock-parents = <&clock CLK_XUSBXTI>;
How about putting these properties in the pmu_system_controller
node? After all the mux clock being configured here belongs to
the PMU subsystem. Wouldn't it work that way ?
> + samsung,i2s-controller = <&i2s0>;
> + samsung,model = "Trats2";
> + samsung,audio-codec = <&wm1811>;
> + samsung,audio-routing =
> + "SPK", "SPKOUTLN",
> + "SPK", "SPKOUTLP",
> + "SPK", "SPKOUTRN",
> + "SPK", "SPKOUTRP";
> + };
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2
Date: Wed, 21 Jan 2015 17:23:21 +0100 [thread overview]
Message-ID: <54BFD279.7080604@samsung.com> (raw)
In-Reply-To: <1421660902-29679-4-git-send-email-ideal.song@samsung.com>
Hi,
On 19/01/15 10:48, Inha Song wrote:
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> + sound {
> + compatible = "samsung,trats2-audio";
> + assigned-clocks = <&pmu_system_controller 0>;
> + assigned-clock-parents = <&clock CLK_XUSBXTI>;
How about putting these properties in the pmu_system_controller
node? After all the mux clock being configured here belongs to
the PMU subsystem. Wouldn't it work that way ?
> + samsung,i2s-controller = <&i2s0>;
> + samsung,model = "Trats2";
> + samsung,audio-codec = <&wm1811>;
> + samsung,audio-routing =
> + "SPK", "SPKOUTLN",
> + "SPK", "SPKOUTLP",
> + "SPK", "SPKOUTRN",
> + "SPK", "SPKOUTRP";
> + };
--
Regards,
Sylwester
next prev parent reply other threads:[~2015-01-21 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:48 [alsa-devel] [PATCH v2 0/3] Sound support for Exynos4412 Trats2 board Inha Song
2015-01-19 9:48 ` Inha Song
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 1/3] ASoC: samsung: Add machine driver for Trats2 Inha Song
2015-01-19 9:48 ` Inha Song
[not found] ` <1421660902-29679-1-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings Inha Song
2015-01-19 9:48 ` Inha Song
2015-01-19 9:48 ` Inha Song
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2 Inha Song
2015-01-19 9:48 ` Inha Song
2015-01-21 16:23 ` Sylwester Nawrocki [this message]
2015-01-21 16:23 ` Sylwester Nawrocki
2015-01-22 1:18 ` Inha Song
2015-01-22 1:18 ` Inha Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BFD279.7080604@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ideal.song@samsung.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.