All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	lee.jone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver
Date: Thu, 22 Jan 2015 12:59:12 +0900	[thread overview]
Message-ID: <54C07590.9080707@samsung.com> (raw)
In-Reply-To: <20150122031240.GA17627-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>

Thank you for review.

On 01/22/2015 12:12 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Jan 22, 2015 at 09:38:11AM +0900, Beomho Seo wrote:
>> This patch add device driver of Richtek RT5033 PMIC. The driver
>> support switching charger. rt5033 charger provide three charging
>> mode.  Three charging mode are pre charge mode, fast cahrge mode
>> and constant voltage mode. They are have vary charge rate, charge
>> parameters. The charge parameters can be controlled by i2c
>> interface.
>>
>> [...]
>>
>> +	charger->psy.name = "rt5033-charger",
>> +	charger->psy.type = POWER_SUPPLY_TYPE_BATTERY,
>>
>> [...]
> 
> POWER_SUPPLY_TYPE_MAINS?
> 
> -- Sebastian
> 

OK I will change power supply type.

Thanks,
Beomho Seo

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Beomho Seo <beomho.seo@samsung.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	lee.jone@linaro.org, broonie@kernel.org, dbaryshkov@gmail.com,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	cw00.choi@samsung.com, inki.dae@samsung.com,
	sw0312.kim@samsung.com, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver
Date: Thu, 22 Jan 2015 12:59:12 +0900	[thread overview]
Message-ID: <54C07590.9080707@samsung.com> (raw)
In-Reply-To: <20150122031240.GA17627@earth.universe>

Thank you for review.

On 01/22/2015 12:12 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Jan 22, 2015 at 09:38:11AM +0900, Beomho Seo wrote:
>> This patch add device driver of Richtek RT5033 PMIC. The driver
>> support switching charger. rt5033 charger provide three charging
>> mode.  Three charging mode are pre charge mode, fast cahrge mode
>> and constant voltage mode. They are have vary charge rate, charge
>> parameters. The charge parameters can be controlled by i2c
>> interface.
>>
>> [...]
>>
>> +	charger->psy.name = "rt5033-charger",
>> +	charger->psy.type = POWER_SUPPLY_TYPE_BATTERY,
>>
>> [...]
> 
> POWER_SUPPLY_TYPE_MAINS?
> 
> -- Sebastian
> 

OK I will change power supply type.

Thanks,
Beomho Seo


  parent reply	other threads:[~2015-01-22  3:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  0:38 [PATCH v3 0/2] power: rt5033: Add Richtek RT533 drivers Beomho Seo
2015-01-22  0:38 ` [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver Beomho Seo
     [not found]   ` <1421887092-4070-2-git-send-email-beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-22  3:12     ` Sebastian Reichel
2015-01-22  3:12       ` Sebastian Reichel
     [not found]       ` <20150122031240.GA17627-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2015-01-22  3:59         ` Beomho Seo [this message]
2015-01-22  3:59           ` Beomho Seo
     [not found] ` <1421887092-4070-1-git-send-email-beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-22  0:38   ` [PATCH v3 2/2] Documentation: Add documentation for rt5033 multifunction device Beomho Seo
2015-01-22  0:38     ` Beomho Seo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C07590.9080707@samsung.com \
    --to=beomho.seo-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=lee.jone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.