From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] clocksource: devicetree: document Conexant Digicolor timer binding
Date: Thu, 22 Jan 2015 13:23:33 +0100 [thread overview]
Message-ID: <54C0EBC5.7060606@linaro.org> (raw)
In-Reply-To: <6812ad4ac585e40ad7d8282eef1d64be8bc6eaa5.1421821466.git.baruch@tkos.co.il>
On 01/21/2015 07:36 AM, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Please add a changelog and a more verbose description: see for example
commit 2f2b7fb2 or 926b65e2. If there is a public documentation please
add a link to it or give a quick description of how the timer behaves.
Also that will help to review the code in the timer.
> ---
> .../devicetree/bindings/timer/digicolor-timer.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/digicolor-timer.txt b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
> new file mode 100644
> index 000000000000..d1b659bbc29f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
> @@ -0,0 +1,18 @@
> +Conexant Digicolor SoCs Timer Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-timer"
> +- reg : Specifies base physical address and size of the "Agent Communication"
> + timer registers
> +- interrupts : Contains 8 interrupts, one for each timer
> +- clocks: phandle to the main clock
> +
> +Example:
> +
> + timer at f0000fc0 {
> + compatible = "cnxt,cx92755-timer";
> + reg = <0xf0000fc0 0x40>;
> + interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
> + clocks = <&main_clk>;
> + };
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] clocksource: devicetree: document Conexant Digicolor timer binding
Date: Thu, 22 Jan 2015 13:23:33 +0100 [thread overview]
Message-ID: <54C0EBC5.7060606@linaro.org> (raw)
In-Reply-To: <6812ad4ac585e40ad7d8282eef1d64be8bc6eaa5.1421821466.git.baruch@tkos.co.il>
On 01/21/2015 07:36 AM, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Please add a changelog and a more verbose description: see for example
commit 2f2b7fb2 or 926b65e2. If there is a public documentation please
add a link to it or give a quick description of how the timer behaves.
Also that will help to review the code in the timer.
> ---
> .../devicetree/bindings/timer/digicolor-timer.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/digicolor-timer.txt b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
> new file mode 100644
> index 000000000000..d1b659bbc29f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
> @@ -0,0 +1,18 @@
> +Conexant Digicolor SoCs Timer Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-timer"
> +- reg : Specifies base physical address and size of the "Agent Communication"
> + timer registers
> +- interrupts : Contains 8 interrupts, one for each timer
> +- clocks: phandle to the main clock
> +
> +Example:
> +
> + timer@f0000fc0 {
> + compatible = "cnxt,cx92755-timer";
> + reg = <0xf0000fc0 0x40>;
> + interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
> + clocks = <&main_clk>;
> + };
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-01-22 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 6:36 [PATCH v3 0/2] clocksource: Conexant CX92755 timers support Baruch Siach
2015-01-21 6:36 ` Baruch Siach
2015-01-21 6:36 ` [PATCH v3 1/2] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-21 6:36 ` Baruch Siach
2015-01-22 12:23 ` Daniel Lezcano [this message]
2015-01-22 12:23 ` Daniel Lezcano
2015-01-21 6:36 ` [PATCH v3 2/2] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-21 6:36 ` Baruch Siach
2015-01-22 12:54 ` Daniel Lezcano
2015-01-22 12:54 ` Daniel Lezcano
2015-01-25 14:46 ` Baruch Siach
2015-01-25 14:46 ` Baruch Siach
2015-01-25 15:03 ` Daniel Lezcano
2015-01-25 15:03 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0EBC5.7060606@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.