All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 3/5] mm, compaction: encapsulate resetting cached scanner positions
Date: Thu, 22 Jan 2015 16:22:20 +0100	[thread overview]
Message-ID: <54C115AC.9030606@suse.cz> (raw)
In-Reply-To: <54BE5885.7030506@gmail.com>

On 01/20/2015 02:30 PM, Zhang Yanfei wrote:
> a?? 2015/1/19 18:05, Vlastimil Babka a??e??:
>> Reseting the cached compaction scanner positions is now done implicitly in
>> __reset_isolation_suitable() and compact_finished(). Encapsulate the
>> functionality in a new function reset_cached_positions() and call it
>> explicitly where needed.
>>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Thanks.

> Should the new function be inline?

I'll try comparing with bloat-o-meter before next submission, if there's 
any difference.

> Thanks.
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 3/5] mm, compaction: encapsulate resetting cached scanner positions
Date: Thu, 22 Jan 2015 16:22:20 +0100	[thread overview]
Message-ID: <54C115AC.9030606@suse.cz> (raw)
In-Reply-To: <54BE5885.7030506@gmail.com>

On 01/20/2015 02:30 PM, Zhang Yanfei wrote:
> 在 2015/1/19 18:05, Vlastimil Babka 写道:
>> Reseting the cached compaction scanner positions is now done implicitly in
>> __reset_isolation_suitable() and compact_finished(). Encapsulate the
>> functionality in a new function reset_cached_positions() and call it
>> explicitly where needed.
>>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Thanks.

> Should the new function be inline?

I'll try comparing with bloat-o-meter before next submission, if there's 
any difference.

> Thanks.
>


  reply	other threads:[~2015-01-22 15:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 10:05 [RFC PATCH 0/5] compaction: changing initial position of scanners Vlastimil Babka
2015-01-19 10:05 ` Vlastimil Babka
2015-01-19 10:05 ` [PATCH 1/5] mm, compaction: more robust check for scanners meeting Vlastimil Babka
2015-01-19 10:05   ` Vlastimil Babka
2015-01-20 13:26   ` Zhang Yanfei
2015-01-20 13:26     ` Zhang Yanfei
2015-01-19 10:05 ` [PATCH 2/5] mm, compaction: simplify handling restart position in free pages scanner Vlastimil Babka
2015-01-19 10:05   ` Vlastimil Babka
2015-01-20 13:27   ` Zhang Yanfei
2015-01-20 13:27     ` Zhang Yanfei
2015-01-20 13:31     ` Vlastimil Babka
2015-01-20 13:31       ` Vlastimil Babka
2015-01-19 10:05 ` [PATCH 3/5] mm, compaction: encapsulate resetting cached scanner positions Vlastimil Babka
2015-01-19 10:05   ` Vlastimil Babka
2015-01-20 13:30   ` Zhang Yanfei
2015-01-20 13:30     ` Zhang Yanfei
2015-01-22 15:22     ` Vlastimil Babka [this message]
2015-01-22 15:22       ` Vlastimil Babka
2015-01-19 10:05 ` [RFC PATCH 4/5] mm, compaction: allow scanners to start at any pfn within the zone Vlastimil Babka
2015-01-19 10:05   ` Vlastimil Babka
2015-01-20 15:18   ` Zhang Yanfei
2015-01-20 15:18     ` Zhang Yanfei
2015-01-22 15:24     ` Vlastimil Babka
2015-01-22 15:24       ` Vlastimil Babka
2015-01-19 10:05 ` [RFC PATCH 5/5] mm, compaction: set pivot pfn to the pfn when scanners met last time Vlastimil Babka
2015-01-19 10:05   ` Vlastimil Babka
2015-01-19 10:10 ` [RFC PATCH 0/5] compaction: changing initial position of scanners Vlastimil Babka
2015-01-19 10:10   ` Vlastimil Babka
2015-01-20  9:02 ` Vlastimil Babka
2015-01-20  9:02   ` Vlastimil Babka
2015-02-03  6:49 ` Joonsoo Kim
2015-02-03  6:49   ` Joonsoo Kim
2015-02-03  9:05   ` Vlastimil Babka
2015-02-03  9:05     ` Vlastimil Babka
2015-02-03 15:00     ` Joonsoo Kim
2015-02-03 15:00       ` Joonsoo Kim
2015-02-03 15:51       ` Vlastimil Babka
2015-02-03 15:51         ` Vlastimil Babka
2015-02-03 17:07         ` Joonsoo Kim
2015-02-03 17:07           ` Joonsoo Kim
2015-02-04 14:39           ` Vlastimil Babka
2015-02-04 14:39             ` Vlastimil Babka
2015-02-10  8:54             ` Joonsoo Kim
2015-02-10  8:54               ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C115AC.9030606@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=zhangyanfei.yes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.