All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Vinayak Menon <vinmenon@codeaurora.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, mgorman@suse.de, minchan@kernel.org,
	iamjoonsoo.kim@lge.com
Subject: Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated
Date: Thu, 22 Jan 2015 16:38:42 +0100	[thread overview]
Message-ID: <54C11982.9070802@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1501211656160.28120@chino.kir.corp.google.com>

On 01/22/2015 01:58 AM, David Rientjes wrote:
>> I think in case of async compaction, we could skip the safe stuff and just
>> terminate it - it's already done when too_many_isolated returns true, and
>> there's no congestion waiting in that case.
>>
>> So you could extend the too_many_isolated() with "safe" parameter (as you did
>> for vmscan) and pass it "cc->mode != MIGRATE_ASYNC" value from
>> isolate_migrate_block().
>>
>
> Or just pass it struct compact_control *cc and use both cc->zone and
> cc->mode inside this compaction-only function.

Yeah,

in any case, please wait until the discussion about the vmscan fix is 
resolved, before reposting this.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Vinayak Menon <vinmenon@codeaurora.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, mgorman@suse.de, minchan@kernel.org,
	iamjoonsoo.kim@lge.com
Subject: Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated
Date: Thu, 22 Jan 2015 16:38:42 +0100	[thread overview]
Message-ID: <54C11982.9070802@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1501211656160.28120@chino.kir.corp.google.com>

On 01/22/2015 01:58 AM, David Rientjes wrote:
>> I think in case of async compaction, we could skip the safe stuff and just
>> terminate it - it's already done when too_many_isolated returns true, and
>> there's no congestion waiting in that case.
>>
>> So you could extend the too_many_isolated() with "safe" parameter (as you did
>> for vmscan) and pass it "cc->mode != MIGRATE_ASYNC" value from
>> isolate_migrate_block().
>>
>
> Or just pass it struct compact_control *cc and use both cc->zone and
> cc->mode inside this compaction-only function.

Yeah,

in any case, please wait until the discussion about the vmscan fix is 
resolved, before reposting this.

Thanks.


  reply	other threads:[~2015-01-22 15:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  9:34 [PATCH] mm: compaction: fix the page state calculation in too_many_isolated Vinayak Menon
2015-01-21  9:34 ` Vinayak Menon
2015-01-21 10:01 ` Vlastimil Babka
2015-01-21 10:01   ` Vlastimil Babka
2015-01-22  0:58   ` David Rientjes
2015-01-22  0:58     ` David Rientjes
2015-01-22 15:38     ` Vlastimil Babka [this message]
2015-01-22 15:38       ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C11982.9070802@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=rientjes@google.com \
    --cc=vinmenon@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.