ChangeLog is generated from gitlog now.

ChangeLog is generated from gitlog now.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

It's generated only on creation of dist archive.
This also has implications to the git commit message format used.
Now git commit message follows standard git commit writing rules rather
than one-off rules which resulted from CSV->SVN->BZR->Git transitions.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

Re: ChangeLog is generated from gitlog now.

[Andrei Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

В Sat, 24 Jan 2015 17:33:44 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> It's generated only on creation of dist archive.
> This also has implications to the git commit message format used.
> Now git commit message follows standard git commit writing rules rather
> than one-off rules which resulted from CSV->SVN->BZR->Git transitions.
> 

> +ChangeLog: FORCE
> +       if test -d $(top_srcdir)/.git; then \
> +               $(gitlog_to_changelog) --srcdir=$(top_srcdir) --since=$(changelog_start_date) > '$@.tmp'; \
> +               rm -f '$@'; mv '$@.tmp' '$@'; \
> +       fi
> +
> +EXTRA_DIST += ChangeLog ChangeLog-2015


This breaks make dist from git checkout, where repository is not
available. May be empty ChangeLog should be created by autogen.sh.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: ChangeLog is generated from gitlog now.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

On 24.01.2015 19:37, Andrei Borzenkov wrote:
> В Sat, 24 Jan 2015 17:33:44 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> 
>> It's generated only on creation of dist archive.
>> This also has implications to the git commit message format used.
>> Now git commit message follows standard git commit writing rules rather
>> than one-off rules which resulted from CSV->SVN->BZR->Git transitions.
>>
> 
>> +ChangeLog: FORCE
>> +       if test -d $(top_srcdir)/.git; then \
>> +               $(gitlog_to_changelog) --srcdir=$(top_srcdir) --since=$(changelog_start_date) > '$@.tmp'; \
>> +               rm -f '$@'; mv '$@.tmp' '$@'; \
>> +       fi
>> +
>> +EXTRA_DIST += ChangeLog ChangeLog-2015
> 
> 
> This breaks make dist from git checkout, where repository is not
> available. May be empty ChangeLog should be created by autogen.sh.
> 
Would this patch fix your issue?
diff --git a/Makefile.am b/Makefile.am
index df0a728..a9f5780 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -447,6 +447,8 @@ ChangeLog: FORCE
        if test -d $(top_srcdir)/.git; then \
                $(gitlog_to_changelog) --srcdir=$(top_srcdir)
--since=$(changelog_start_date) > '$@.tmp'; \
                rm -f '$@'; mv '$@.tmp' '$@'; \
+       else \
+               touch $@; \
        fi

 EXTRA_DIST += ChangeLog ChangeLog-2015

> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

Re: ChangeLog is generated from gitlog now.

[Andrei Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

В Sat, 24 Jan 2015 19:55:32 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 24.01.2015 19:37, Andrei Borzenkov wrote:
> > В Sat, 24 Jan 2015 17:33:44 +0100
> > Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> > 
> >> It's generated only on creation of dist archive.
> >> This also has implications to the git commit message format used.
> >> Now git commit message follows standard git commit writing rules rather
> >> than one-off rules which resulted from CSV->SVN->BZR->Git transitions.
> >>
> > 
> >> +ChangeLog: FORCE
> >> +       if test -d $(top_srcdir)/.git; then \
> >> +               $(gitlog_to_changelog) --srcdir=$(top_srcdir) --since=$(changelog_start_date) > '$@.tmp'; \
> >> +               rm -f '$@'; mv '$@.tmp' '$@'; \
> >> +       fi
> >> +
> >> +EXTRA_DIST += ChangeLog ChangeLog-2015
> > 
> > 
> > This breaks make dist from git checkout, where repository is not
> > available. May be empty ChangeLog should be created by autogen.sh.

yes. Thank you!

> > 
> Would this patch fix your issue?
> diff --git a/Makefile.am b/Makefile.am
> index df0a728..a9f5780 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -447,6 +447,8 @@ ChangeLog: FORCE
>         if test -d $(top_srcdir)/.git; then \
>                 $(gitlog_to_changelog) --srcdir=$(top_srcdir)
> --since=$(changelog_start_date) > '$@.tmp'; \
>                 rm -f '$@'; mv '$@.tmp' '$@'; \
> +       else \
> +               touch $@; \
>         fi
> 
>  EXTRA_DIST += ChangeLog ChangeLog-2015
> 
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: ChangeLog is generated from gitlog now.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]

On 24.01.2015 20:07, Andrei Borzenkov wrote:
> В Sat, 24 Jan 2015 19:55:32 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> 
>> On 24.01.2015 19:37, Andrei Borzenkov wrote:
>>> В Sat, 24 Jan 2015 17:33:44 +0100
>>> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>>>
>>>> It's generated only on creation of dist archive.
>>>> This also has implications to the git commit message format used.
>>>> Now git commit message follows standard git commit writing rules rather
>>>> than one-off rules which resulted from CSV->SVN->BZR->Git transitions.
>>>>
>>>
>>>> +ChangeLog: FORCE
>>>> +       if test -d $(top_srcdir)/.git; then \
>>>> +               $(gitlog_to_changelog) --srcdir=$(top_srcdir) --since=$(changelog_start_date) > '$@.tmp'; \
>>>> +               rm -f '$@'; mv '$@.tmp' '$@'; \
>>>> +       fi
>>>> +
>>>> +EXTRA_DIST += ChangeLog ChangeLog-2015
>>>
>>>
>>> This breaks make dist from git checkout, where repository is not
>>> available. May be empty ChangeLog should be created by autogen.sh.
> 
> yes. Thank you!
> 
committed, thanks.
>>>
>> Would this patch fix your issue?
>> diff --git a/Makefile.am b/Makefile.am
>> index df0a728..a9f5780 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -447,6 +447,8 @@ ChangeLog: FORCE
>>         if test -d $(top_srcdir)/.git; then \
>>                 $(gitlog_to_changelog) --srcdir=$(top_srcdir)
>> --since=$(changelog_start_date) > '$@.tmp'; \
>>                 rm -f '$@'; mv '$@.tmp' '$@'; \
>> +       else \
>> +               touch $@; \
>>         fi
>>
>>  EXTRA_DIST += ChangeLog ChangeLog-2015
>>
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>
>>
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]