From: Vlastimil Babka <vbabka@suse.cz>
To: Andrea Arcangeli <aarcange@redhat.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill@shutemov.name, mhocko@suse.cz, mgorman@suse.de,
rientjes@google.com, sasha.levin@oracle.com, hughd@google.com,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH] mm: incorporate read-only pages into transparent huge pages
Date: Sun, 25 Jan 2015 10:25:20 +0100 [thread overview]
Message-ID: <54C4B680.3010304@suse.cz> (raw)
In-Reply-To: <20150123191816.GN11755@redhat.com>
On 23.1.2015 20:18, Andrea Arcangeli wrote:
>> >+ if (!pte_write(pteval)) {
>> >+ if (++ro > khugepaged_max_ptes_none)
>> >+ goto out_unmap;
>> >+ }
> It's true this is maxed out at 511, so there must be at least one
> writable and not none pte (as results of the two "ro" and "none"
> counters checks).
Hm, but if we consider ro and pte_none separately, both can be lower
than 512, but the sum of the two can be 512, so we can actually be in
read-only VMA?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Andrea Arcangeli <aarcange@redhat.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill@shutemov.name, mhocko@suse.cz, mgorman@suse.de,
rientjes@google.com, sasha.levin@oracle.com, hughd@google.com,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH] mm: incorporate read-only pages into transparent huge pages
Date: Sun, 25 Jan 2015 10:25:20 +0100 [thread overview]
Message-ID: <54C4B680.3010304@suse.cz> (raw)
In-Reply-To: <20150123191816.GN11755@redhat.com>
On 23.1.2015 20:18, Andrea Arcangeli wrote:
>> >+ if (!pte_write(pteval)) {
>> >+ if (++ro > khugepaged_max_ptes_none)
>> >+ goto out_unmap;
>> >+ }
> It's true this is maxed out at 511, so there must be at least one
> writable and not none pte (as results of the two "ro" and "none"
> counters checks).
Hm, but if we consider ro and pte_none separately, both can be lower
than 512, but the sum of the two can be 512, so we can actually be in
read-only VMA?
next prev parent reply other threads:[~2015-01-25 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 7:47 [PATCH] mm: incorporate read-only pages into transparent huge pages Ebru Akagunduz
2015-01-23 7:47 ` Ebru Akagunduz
2015-01-23 11:37 ` Kirill A. Shutemov
2015-01-23 11:37 ` Kirill A. Shutemov
2015-01-23 14:57 ` Rik van Riel
2015-01-23 14:57 ` Rik van Riel
2015-01-23 15:58 ` Kirill A. Shutemov
2015-01-23 15:58 ` Kirill A. Shutemov
2015-01-23 16:12 ` Vlastimil Babka
2015-01-23 16:12 ` Vlastimil Babka
2015-01-23 16:15 ` Rik van Riel
2015-01-23 16:15 ` Rik van Riel
2015-01-23 19:04 ` Rik van Riel
2015-01-23 19:04 ` Rik van Riel
2015-01-23 19:18 ` Andrea Arcangeli
2015-01-23 19:18 ` Andrea Arcangeli
2015-01-25 9:25 ` Vlastimil Babka [this message]
2015-01-25 9:25 ` Vlastimil Babka
2015-01-25 14:42 ` Zhang Yanfei
2015-01-25 14:42 ` Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C4B680.3010304@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebru.akagunduz@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.