All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Klausmann <tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
To: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] fuse/gm107: simplify the return logic
Date: Sun, 25 Jan 2015 20:41:16 +0100	[thread overview]
Message-ID: <54C546DC.2010004@mni.thm.de> (raw)
In-Reply-To: <1422214544-2181-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>


On 25.01.2015 20:35, Martin Peres wrote:
> Spotted by coccinelle: 
> drivers/gpu/drm/nouveau/core/subdev/fuse/gm107.c:50:5-8: WARNING: end 
> returns can be simpified Signed-off-by: Martin Peres 
> <martin.peres@free.fr> --- drm/nouveau/nvkm/subdev/fuse/gm107.c | 4 
> +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git 
> a/drm/nouveau/nvkm/subdev/fuse/gm107.c 
> b/drm/nouveau/nvkm/subdev/fuse/gm107.c index ba19158..0b256aa 100644 
> --- a/drm/nouveau/nvkm/subdev/fuse/gm107.c +++ 
> b/drm/nouveau/nvkm/subdev/fuse/gm107.c @@ -45,10 +45,8 @@ 
> gm107_fuse_ctor(struct nvkm_object *parent, struct nvkm_object 
> *engine, ret = nvkm_fuse_create(parent, engine, oclass, &priv); 
> *pobject = nv_object(priv); - if (ret) - return ret; - return 0; + 
> return ret; } struct nvkm_oclass

Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>

If it is helping :)
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2015-01-25 19:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 19:35 [PATCH] fuse/gm107: simplify the return logic Martin Peres
     [not found] ` <1422214544-2181-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2015-01-25 19:41   ` Tobias Klausmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C546DC.2010004@mni.thm.de \
    --to=tobias.johannes.klausmann-aqjdnwhu20eelga04laivw@public.gmane.org \
    --cc=martin.peres-GANU6spQydw@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.