[PATCH] fuse/gm107: simplify the return logic

[PATCH] fuse/gm107: simplify the return logic

[Martin Peres]

Spotted by coccinelle:
drivers/gpu/drm/nouveau/core/subdev/fuse/gm107.c:50:5-8: WARNING: end returns can be simpified

Signed-off-by: Martin Peres <martin.peres@free.fr>
---
 drm/nouveau/nvkm/subdev/fuse/gm107.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drm/nouveau/nvkm/subdev/fuse/gm107.c b/drm/nouveau/nvkm/subdev/fuse/gm107.c
index ba19158..0b256aa 100644
--- a/drm/nouveau/nvkm/subdev/fuse/gm107.c
+++ b/drm/nouveau/nvkm/subdev/fuse/gm107.c
@@ -45,10 +45,8 @@ gm107_fuse_ctor(struct nvkm_object *parent, struct nvkm_object *engine,
 
 	ret = nvkm_fuse_create(parent, engine, oclass, &priv);
 	*pobject = nv_object(priv);
-	if (ret)
-		return ret;
 
-	return 0;
+	return ret;
 }
 
 struct nvkm_oclass
-- 
2.2.2

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] fuse/gm107: simplify the return logic

[Tobias Klausmann]

On 25.01.2015 20:35, Martin Peres wrote:
> Spotted by coccinelle: 
> drivers/gpu/drm/nouveau/core/subdev/fuse/gm107.c:50:5-8: WARNING: end 
> returns can be simpified Signed-off-by: Martin Peres 
> <martin.peres@free.fr> --- drm/nouveau/nvkm/subdev/fuse/gm107.c | 4 
> +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git 
> a/drm/nouveau/nvkm/subdev/fuse/gm107.c 
> b/drm/nouveau/nvkm/subdev/fuse/gm107.c index ba19158..0b256aa 100644 
> --- a/drm/nouveau/nvkm/subdev/fuse/gm107.c +++ 
> b/drm/nouveau/nvkm/subdev/fuse/gm107.c @@ -45,10 +45,8 @@ 
> gm107_fuse_ctor(struct nvkm_object *parent, struct nvkm_object 
> *engine, ret = nvkm_fuse_create(parent, engine, oclass, &priv); 
> *pobject = nv_object(priv); - if (ret) - return ret; - return 0; + 
> return ret; } struct nvkm_oclass

Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>

If it is helping :)
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau