* [PATCH] x86,xen: use current->state helpers
@ 2015-01-26 10:10 Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2015-01-26 10:10 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: xen-devel, Davidlohr Bueso, David Vrabel
Call __set_current_state() instead of assigning the new state directly.
These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
keeping track of who changed the state.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
arch/x86/xen/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 4c071ae..08e8489 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -507,7 +507,7 @@ static int xen_cpu_disable(void)
static void xen_cpu_die(unsigned int cpu)
{
while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
- current->state = TASK_UNINTERRUPTIBLE;
+ __set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(HZ/10);
}
--
2.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86,xen: use current->state helpers
2015-01-26 10:10 [PATCH] x86,xen: use current->state helpers Davidlohr Bueso
@ 2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:24 ` David Vrabel
2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2015-01-26 10:11 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky, David Vrabel, xen-devel, linux-kernel
Oops, cc'ing lkml.
On Mon, 2015-01-26 at 02:10 -0800, Davidlohr Bueso wrote:
> Call __set_current_state() instead of assigning the new state directly.
> These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
> keeping track of who changed the state.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> arch/x86/xen/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
> index 4c071ae..08e8489 100644
> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
> @@ -507,7 +507,7 @@ static int xen_cpu_disable(void)
> static void xen_cpu_die(unsigned int cpu)
> {
> while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
> - current->state = TASK_UNINTERRUPTIBLE;
> + __set_current_state(TASK_UNINTERRUPTIBLE);
> schedule_timeout(HZ/10);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86,xen: use current->state helpers
2015-01-26 10:10 [PATCH] x86,xen: use current->state helpers Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
@ 2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:24 ` David Vrabel
2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2015-01-26 10:11 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: xen-devel, Boris Ostrovsky, David Vrabel, linux-kernel
Oops, cc'ing lkml.
On Mon, 2015-01-26 at 02:10 -0800, Davidlohr Bueso wrote:
> Call __set_current_state() instead of assigning the new state directly.
> These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
> keeping track of who changed the state.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> arch/x86/xen/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
> index 4c071ae..08e8489 100644
> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
> @@ -507,7 +507,7 @@ static int xen_cpu_disable(void)
> static void xen_cpu_die(unsigned int cpu)
> {
> while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
> - current->state = TASK_UNINTERRUPTIBLE;
> + __set_current_state(TASK_UNINTERRUPTIBLE);
> schedule_timeout(HZ/10);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86,xen: use current->state helpers
2015-01-26 10:10 [PATCH] x86,xen: use current->state helpers Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
@ 2015-01-26 10:24 ` David Vrabel
2 siblings, 0 replies; 4+ messages in thread
From: David Vrabel @ 2015-01-26 10:24 UTC (permalink / raw)
To: Davidlohr Bueso, Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: xen-devel, David Vrabel
On 26/01/15 10:10, Davidlohr Bueso wrote:
> Call __set_current_state() instead of assigning the new state directly.
> These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
> keeping track of who changed the state.
Applied to devel/for-linus-3.20, thanks.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-26 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-26 10:10 [PATCH] x86,xen: use current->state helpers Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:11 ` Davidlohr Bueso
2015-01-26 10:24 ` David Vrabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.