From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] clocksource: driver for Conexant Digicolor SoC timer
Date: Mon, 26 Jan 2015 11:26:45 +0100 [thread overview]
Message-ID: <54C61665.1000300@linaro.org> (raw)
In-Reply-To: <20150126101511.GC3148@tarshish>
On 01/26/2015 11:15 AM, Baruch Siach wrote:
> Hi Daniel,
[ ... ]
>>
>> What do you think ?
>
> OK. I'll give it a try.
>
> Thanks for your prompt response and thorough review.
Maxime Ripard just sent a patchset (patch 4/5) with some changes
suggested above :)
http://www.spinics.net/lists/arm-kernel/msg394704.html
As you may see, the enable/disable is passing the timer channel as
parameter while I suggested to store it in the structure. It is up to
you to choose what fits better for your future needs.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] clocksource: driver for Conexant Digicolor SoC timer
Date: Mon, 26 Jan 2015 11:26:45 +0100 [thread overview]
Message-ID: <54C61665.1000300@linaro.org> (raw)
In-Reply-To: <20150126101511.GC3148@tarshish>
On 01/26/2015 11:15 AM, Baruch Siach wrote:
> Hi Daniel,
[ ... ]
>>
>> What do you think ?
>
> OK. I'll give it a try.
>
> Thanks for your prompt response and thorough review.
Maxime Ripard just sent a patchset (patch 4/5) with some changes
suggested above :)
http://www.spinics.net/lists/arm-kernel/msg394704.html
As you may see, the enable/disable is passing the timer channel as
parameter while I suggested to store it in the structure. It is up to
you to choose what fits better for your future needs.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-01-26 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 7:56 [PATCH v4 0/2] clocksource: Conexant CX92755 timers support Baruch Siach
2015-01-26 7:56 ` Baruch Siach
2015-01-26 7:56 ` [PATCH v4 1/2] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-26 7:56 ` Baruch Siach
2015-01-26 7:56 ` [PATCH v4 2/2] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-26 7:56 ` Baruch Siach
2015-01-26 9:43 ` Daniel Lezcano
2015-01-26 9:43 ` Daniel Lezcano
2015-01-26 10:15 ` Baruch Siach
2015-01-26 10:15 ` Baruch Siach
2015-01-26 10:26 ` Daniel Lezcano [this message]
2015-01-26 10:26 ` Daniel Lezcano
2015-01-26 10:38 ` Thomas Gleixner
2015-01-26 10:38 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C61665.1000300@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.