All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: sis: remove unused variables
Date: Mon, 26 Jan 2015 12:37:26 +0000	[thread overview]
Message-ID: <54C63506.3020106@ti.com> (raw)
In-Reply-To: <1421940699-20670-1-git-send-email-sudipm.mukherjee@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On 22/01/15 17:31, Sudip Mukherjee wrote:
> removed some variables which were not used. Few calls to SiS_GetReg()
> were left behind as they are reading from the hardare, removing them
> might affect the overall functionality.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> This patch will generate checkpatch error, to fix that error we need
> to change the style of init.c and init301.c
> 
>  drivers/video/fbdev/sis/init.c     | 33 +++++----------------------------
>  drivers/video/fbdev/sis/init301.c  | 10 ++--------
>  drivers/video/fbdev/sis/sis_main.c |  9 ++++-----
>  3 files changed, 11 insertions(+), 41 deletions(-)

Are you able to test this?

The patch doesn't look too complex, but it's still slightly too complex
for me to comfortably merge it without any testing.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: sis: remove unused variables
Date: Mon, 26 Jan 2015 14:37:26 +0200	[thread overview]
Message-ID: <54C63506.3020106@ti.com> (raw)
In-Reply-To: <1421940699-20670-1-git-send-email-sudipm.mukherjee@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On 22/01/15 17:31, Sudip Mukherjee wrote:
> removed some variables which were not used. Few calls to SiS_GetReg()
> were left behind as they are reading from the hardare, removing them
> might affect the overall functionality.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> This patch will generate checkpatch error, to fix that error we need
> to change the style of init.c and init301.c
> 
>  drivers/video/fbdev/sis/init.c     | 33 +++++----------------------------
>  drivers/video/fbdev/sis/init301.c  | 10 ++--------
>  drivers/video/fbdev/sis/sis_main.c |  9 ++++-----
>  3 files changed, 11 insertions(+), 41 deletions(-)

Are you able to test this?

The patch doesn't look too complex, but it's still slightly too complex
for me to comfortably merge it without any testing.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-26 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 15:31 [PATCH] video: fbdev: sis: remove unused variables Sudip Mukherjee
2015-01-22 15:43 ` Sudip Mukherjee
2015-01-26 12:37 ` Tomi Valkeinen [this message]
2015-01-26 12:37   ` Tomi Valkeinen
2015-01-27 13:08   ` Sudip Mukherjee
2015-01-27 13:20     ` Sudip Mukherjee
  -- strict thread matches above, loose matches on Subject: below --
2016-02-29 18:02 [PATCH] video: fbdev: sis: remove unused variable Sudip Mukherjee
2016-02-29 18:14 ` Sudip Mukherjee
2016-03-03 11:40 ` Tomi Valkeinen
2016-03-03 11:40   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C63506.3020106@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.