Re: [PATCH 7/7 v9] can/peak_usb: add support for PEAK new CANFD USB adapters

[Oliver Hartkopp <socketcan@hartkopp.net>]

>> I assume it is better to set the ctrlmode directly in the struct can_priv
>> element in  pcan_usb_fd_init() after retrieving the firmware version.
>
> Even better.
>
>> IMO it doesn't make sense to transport this info through the mechanic above
>> which mostly initialized quasi constant settings for the adapter.
>
> If we check the firmware version, it doesn't make sende to put the
> information into that struct (IMHO)
>

Just to be sure: We stated to have the same opinion here, right?

>> +/* describes the PCAN-USB Pro FD adapter */
>> +struct peak_usb_adapter pcan_usb_pro_fd = {
>>
>> be
>>
>> +/* describes the PCAN-USB Pro FD adapter */
>> +const struct peak_usb_adapter pcan_usb_pro_fd = {
>
> Yes, but it probably needs some more modifications in the driver.

I don't know if this struct is "read-only" all the time.
If so it is easy to change.

I pity you, Stephane - but we will make it :-))

Thanks,
Oliver