Re: [PATCH 7/7 v9] can/peak_usb: add support for PEAK new CANFD USB adapters

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]

On 01/27/2015 02:02 PM, Stephane Grosjean wrote:
> Hi guys,
> 
> Le 27/01/2015 09:05, Marc Kleine-Budde a écrit :
>> On 01/27/2015 09:00 AM, Oliver Hartkopp wrote:
>>>>> I assume it is better to set the ctrlmode directly in the struct can_priv
>>>>> element in  pcan_usb_fd_init() after retrieving the firmware version.
>>>> Even better.
>>>>
>>>>> IMO it doesn't make sense to transport this info through the mechanic above
>>>>> which mostly initialized quasi constant settings for the adapter.
>>>> If we check the firmware version, it doesn't make sende to put the
>>>> information into that struct (IMHO)
>>> Just to be sure: We stated to have the same opinion here, right?
>> Yes, check the firmware version and set ctrlmode directly.
>>
>>>>> +/* describes the PCAN-USB Pro FD adapter */
>>>>> +struct peak_usb_adapter pcan_usb_pro_fd = {
>>>>>
>>>>> be
>>>>>
>>>>> +/* describes the PCAN-USB Pro FD adapter */
>>>>> +const struct peak_usb_adapter pcan_usb_pro_fd = {
>>>> Yes, but it probably needs some more modifications in the driver.
>>> I don't know if this struct is "read-only" all the time.
>>> If so it is easy to change.
>> I haven't checked but I _think_ it should be possible to make it read
>> only everywhere.
>>
>>> I pity you, Stephane - but we will make it :-))
>> :)
>>
>> Marc
> 
> My :) as well as my ACK too...
> 
> But putting "const" here leads to several other changes in 
> pcan_usb_core.h and pcan_usb_core.c (as well as in older pcan_usb.c and 
> pcan_usb_pro.c files, where same struct peak_adapter static objects are 
> used to define the corresponding USB adapter).
> 
> Do you need another patch which does this, once for all?

Yes, make a patch that converts the existing driver...btw while there
you can convert static struct peak_usb_adapter not to be NULL terminated
but work with ARRAY_SIZE().

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]