All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Gang S <gang.chen@sunrus.com.cn>, riku.voipio@iki.fi
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base
Date: Tue, 27 Jan 2015 18:39:21 +0300	[thread overview]
Message-ID: <54C7B129.90308@msgid.tls.msk.ru> (raw)
In-Reply-To: <54C21D76.8050808@sunrus.com.cn>

23.01.2015 13:07, Chen Gang S wrote:
> It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the
> len.

My suggestion:

Subject: linux-user/syscall.c: unlock_iovec: fix typo misuse of iov_base instead of iov_len

without further explanation in the message body.

Applied as-is to trivial, thank you!

/mjt

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a66c2ae..8260ed7 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1896,7 +1896,7 @@ static void unlock_iovec(struct iovec *vec, abi_ulong target_addr,
>      if (target_vec) {
>          for (i = 0; i < count; i++) {
>              abi_ulong base = tswapal(target_vec[i].iov_base);
> -            abi_long len = tswapal(target_vec[i].iov_base);
> +            abi_long len = tswapal(target_vec[i].iov_len);
>              if (len < 0) {
>                  break;
>              }
> 



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Gang S <gang.chen@sunrus.com.cn>, riku.voipio@iki.fi
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base
Date: Tue, 27 Jan 2015 18:39:21 +0300	[thread overview]
Message-ID: <54C7B129.90308@msgid.tls.msk.ru> (raw)
In-Reply-To: <54C21D76.8050808@sunrus.com.cn>

23.01.2015 13:07, Chen Gang S wrote:
> It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the
> len.

My suggestion:

Subject: linux-user/syscall.c: unlock_iovec: fix typo misuse of iov_base instead of iov_len

without further explanation in the message body.

Applied as-is to trivial, thank you!

/mjt

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a66c2ae..8260ed7 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1896,7 +1896,7 @@ static void unlock_iovec(struct iovec *vec, abi_ulong target_addr,
>      if (target_vec) {
>          for (i = 0; i < count; i++) {
>              abi_ulong base = tswapal(target_vec[i].iov_base);
> -            abi_long len = tswapal(target_vec[i].iov_base);
> +            abi_long len = tswapal(target_vec[i].iov_len);
>              if (len < 0) {
>                  break;
>              }
> 

  parent reply	other threads:[~2015-01-27 15:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:07 [Qemu-trivial] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base Chen Gang S
2015-01-23 10:07 ` [Qemu-devel] " Chen Gang S
2015-01-23 10:08 ` [Qemu-trivial] " Peter Maydell
2015-01-23 10:08   ` Peter Maydell
2015-01-23 10:57   ` [Qemu-trivial] " Chen Gang S
2015-01-23 10:57     ` Chen Gang S
2015-01-23 11:21     ` [Qemu-trivial] " Peter Maydell
2015-01-23 11:21       ` Peter Maydell
2015-01-23 14:01       ` [Qemu-trivial] " Chen Gang S
2015-01-23 14:01         ` Chen Gang S
2015-01-23 13:55         ` [Qemu-trivial] " Peter Maydell
2015-01-23 13:55           ` Peter Maydell
2015-01-23 21:10           ` [Qemu-trivial] " Chen Gang S
2015-01-23 21:10             ` Chen Gang S
2015-01-27 15:39 ` Michael Tokarev [this message]
2015-01-27 15:39   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7B129.90308@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=gang.chen@sunrus.com.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.