[meta-oe][PATCH] samba: disable service by default

[meta-oe][PATCH] samba: disable service by default

[Chong Lu]

Disable smb, nmb, winbind service by default.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta-oe/recipes-connectivity/samba/samba.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-connectivity/samba/samba.inc b/meta-oe/recipes-connectivity/samba/samba.inc
index fd96bbe..b04a9dd 100644
--- a/meta-oe/recipes-connectivity/samba/samba.inc
+++ b/meta-oe/recipes-connectivity/samba/samba.inc
@@ -20,6 +20,8 @@ inherit autotools-brokensep update-rc.d systemd
 SYSTEMD_PACKAGES = "${PN} winbind"
 SYSTEMD_SERVICE_${PN} = "nmb.service smb.service"
 SYSTEMD_SERVICE_winbind = "winbind.service"
+SYSTEMD_AUTO_ENABLE_${PN} = "disable"
+SYSTEMD_AUTO_ENABLE_winbind = "disable"
 
 SAMBAMMAP = "no"
 SAMBAMMAP_libc-glibc = "yes"
-- 
1.9.1

Re: [meta-oe][PATCH] samba: disable service by default

[Paul Eggleton]

Hi Chong,

On Wednesday 28 January 2015 11:23:43 Chong Lu wrote:
> Disable smb, nmb, winbind service by default.

The commit message says what you are doing, but doesn't explain the reason - 
why do you want to do this?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [meta-oe][PATCH] samba: disable service by default

[Chong Lu]

On 01/28/2015 04:59 PM, Paul Eggleton wrote:
> Hi Chong,
>
> On Wednesday 28 January 2015 11:23:43 Chong Lu wrote:
>> Disable smb, nmb, winbind service by default.
> The commit message says what you are doing, but doesn't explain the reason -
> why do you want to do this?
>
> Cheers,
> Paul
>

Hi Paul,

The config file need configure by user, else I think there is no meaning 
for enable samba by default.

Best Regards
Chong

Re: [meta-oe][PATCH] samba: disable service by default

[Paul Eggleton]

On Wednesday 28 January 2015 17:30:19 Chong Lu wrote:
> On 01/28/2015 04:59 PM, Paul Eggleton wrote:
> > Hi Chong,
> > 
> > On Wednesday 28 January 2015 11:23:43 Chong Lu wrote:
> >> Disable smb, nmb, winbind service by default.
> > 
> > The commit message says what you are doing, but doesn't explain the reason
> > - why do you want to do this?
> > 
> 
> The config file need configure by user, else I think there is no meaning
> for enable samba by default.

Surely that's a distro decision though?

I'm just guessing, but if the problem you're trying to address is that the 
services get pulled into an image unexpectedly or where they aren't needed, 
then if at all practical it would be best to try to split the packaging such 
that the needed client/utility binaries are available without those services 
and thus the services should never be in an image they are explicitly 
requested.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre