* [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind
@ 2015-01-28 15:07 Christian Borntraeger
2015-01-28 15:18 ` [Qemu-devel] " Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Christian Borntraeger @ 2015-01-28 15:07 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Marcel Apfelbaum, Christian Borntraeger,
Paolo Bonzini
valgrind complains about:
==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x40DB2E5: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
==42062== by 0x40A96C9: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x80164885: object_class_foreach (object.c:665)
==42062== by 0x80164975: object_class_get_list (object.c:698)
==42062== by 0x800100A5: machine_parse (vl.c:2447)
==42062== by 0x800100A5: main (vl.c:3756)
Lets free machines in case of mc.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 983259b..9d008ac 100644
--- a/vl.c
+++ b/vl.c
@@ -2450,6 +2450,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
mc = find_machine(name);
}
if (mc) {
+ g_slist_free(machines);
return mc;
}
if (name && !is_help_option(name)) {
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind
2015-01-28 15:07 [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind Christian Borntraeger
@ 2015-01-28 15:18 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-01-28 15:18 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel
Cc: qemu-trivial@nongnu.org, Peter Maydell, Marcel Apfelbaum
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
and Ccing qemu-trivial. Funny that we do the g_slist_free before exiting!
Paolo
On 28/01/2015 16:07, Christian Borntraeger wrote:
> valgrind complains about:
> ==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
> ==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
> ==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x40DB2E5: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
> ==42062== by 0x40A96C9: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x80164885: object_class_foreach (object.c:665)
> ==42062== by 0x80164975: object_class_get_list (object.c:698)
> ==42062== by 0x800100A5: machine_parse (vl.c:2447)
> ==42062== by 0x800100A5: main (vl.c:3756)
>
> Lets free machines in case of mc.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 983259b..9d008ac 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2450,6 +2450,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
> mc = find_machine(name);
> }
> if (mc) {
> + g_slist_free(machines);
> return mc;
> }
> if (name && !is_help_option(name)) {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind
@ 2015-01-28 15:18 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-01-28 15:18 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel
Cc: qemu-trivial@nongnu.org, Peter Maydell, Marcel Apfelbaum
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
and Ccing qemu-trivial. Funny that we do the g_slist_free before exiting!
Paolo
On 28/01/2015 16:07, Christian Borntraeger wrote:
> valgrind complains about:
> ==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
> ==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
> ==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x40DB2E5: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
> ==42062== by 0x40A96C9: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.3800.2)
> ==42062== by 0x80164885: object_class_foreach (object.c:665)
> ==42062== by 0x80164975: object_class_get_list (object.c:698)
> ==42062== by 0x800100A5: machine_parse (vl.c:2447)
> ==42062== by 0x800100A5: main (vl.c:3756)
>
> Lets free machines in case of mc.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 983259b..9d008ac 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2450,6 +2450,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
> mc = find_machine(name);
> }
> if (mc) {
> + g_slist_free(machines);
> return mc;
> }
> if (name && !is_help_option(name)) {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind
2015-01-28 15:18 ` [Qemu-devel] " Paolo Bonzini
@ 2015-02-07 9:03 ` Michael Tokarev
-1 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2015-02-07 9:03 UTC (permalink / raw)
To: Paolo Bonzini, Christian Borntraeger, qemu-devel
Cc: qemu-trivial@nongnu.org, Peter Maydell, Marcel Apfelbaum
28.01.2015 18:18, Paolo Bonzini wrote:
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Applied to -trivial, thank you!
/mjt
> On 28/01/2015 16:07, Christian Borntraeger wrote:
>> valgrind complains about:
>> ==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
>> ==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
>> ==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x40DB2E5: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
>> ==42062== by 0x40A96C9: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x80164885: object_class_foreach (object.c:665)
>> ==42062== by 0x80164975: object_class_get_list (object.c:698)
>> ==42062== by 0x800100A5: machine_parse (vl.c:2447)
>> ==42062== by 0x800100A5: main (vl.c:3756)
>>
>> Lets free machines in case of mc.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 983259b..9d008ac 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2450,6 +2450,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
>> mc = find_machine(name);
>> }
>> if (mc) {
>> + g_slist_free(machines);
>> return mc;
>> }
>> if (name && !is_help_option(name)) {
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind
@ 2015-02-07 9:03 ` Michael Tokarev
0 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2015-02-07 9:03 UTC (permalink / raw)
To: Paolo Bonzini, Christian Borntraeger, qemu-devel
Cc: qemu-trivial@nongnu.org, Peter Maydell, Marcel Apfelbaum
28.01.2015 18:18, Paolo Bonzini wrote:
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Applied to -trivial, thank you!
/mjt
> On 28/01/2015 16:07, Christian Borntraeger wrote:
>> valgrind complains about:
>> ==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
>> ==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
>> ==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x40DB2E5: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
>> ==42062== by 0x40A96C9: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.3800.2)
>> ==42062== by 0x80164885: object_class_foreach (object.c:665)
>> ==42062== by 0x80164975: object_class_get_list (object.c:698)
>> ==42062== by 0x800100A5: machine_parse (vl.c:2447)
>> ==42062== by 0x800100A5: main (vl.c:3756)
>>
>> Lets free machines in case of mc.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 983259b..9d008ac 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2450,6 +2450,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
>> mc = find_machine(name);
>> }
>> if (mc) {
>> + g_slist_free(machines);
>> return mc;
>> }
>> if (name && !is_help_option(name)) {
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-07 9:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-28 15:07 [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind Christian Borntraeger
2015-01-28 15:18 ` [Qemu-trivial] " Paolo Bonzini
2015-01-28 15:18 ` [Qemu-devel] " Paolo Bonzini
2015-02-07 9:03 ` [Qemu-trivial] " Michael Tokarev
2015-02-07 9:03 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.