From: cminyard@mvista.com (Corey Minyard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ipmi: avoid gcc warning
Date: Wed, 28 Jan 2015 10:46:21 -0600 [thread overview]
Message-ID: <54C9125D.5040706@mvista.com> (raw)
In-Reply-To: <2457592.UIVPJ2WNL3@wuerfel>
Thanks, queued for 3.20.
-corey
On 01/28/2015 09:00 AM, Arnd Bergmann wrote:
> A new harmless warning has come up on ARM builds with gcc-4.9:
>
> drivers/char/ipmi/ipmi_msghandler.c: In function 'smi_send.isra.11':
> include/linux/spinlock.h:372:95: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
> raw_spin_unlock_irqrestore(&lock->rlock, flags);
> ^
> drivers/char/ipmi/ipmi_msghandler.c:1490:16: note: 'flags' was declared here
> unsigned long flags;
> ^
>
> This could be worked around by initializing the 'flags' variable, but it
> seems better to rework the code to avoid this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7ea0ed2b5be81 ("ipmi: Make the message handler easier to use for SMI interfaces")
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 6b65fa4e0c55..fb0f8eacd208 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -1483,14 +1483,10 @@ static inline void format_lan_msg(struct ipmi_smi_msg *smi_msg,
> smi_msg->msgid = msgid;
> }
>
> -static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> - struct ipmi_smi_msg *smi_msg, int priority)
> +static struct ipmi_smi_msg *smi_add_send_msg(ipmi_smi_t intf,
> + struct ipmi_smi_msg *smi_msg,
> + int priority)
> {
> - int run_to_completion = intf->run_to_completion;
> - unsigned long flags;
> -
> - if (!run_to_completion)
> - spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
> if (intf->curr_msg) {
> if (priority > 0)
> list_add_tail(&smi_msg->link, &intf->hp_xmit_msgs);
> @@ -1500,8 +1496,24 @@ static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> } else {
> intf->curr_msg = smi_msg;
> }
> - if (!run_to_completion)
> +
> + return smi_msg;
> +}
> +
> +
> +static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> + struct ipmi_smi_msg *smi_msg, int priority)
> +{
> + int run_to_completion = intf->run_to_completion;
> +
> + if (run_to_completion) {
> + smi_msg = smi_add_send_msg(intf, smi_msg, priority);
> + } else {
> + unsigned long flags;
> + spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
> + smi_msg = smi_add_send_msg(intf, smi_msg, priority);
> spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
> + }
>
> if (smi_msg)
> handlers->sender(intf->send_info, smi_msg);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Corey Minyard <cminyard@mvista.com>
To: Arnd Bergmann <arnd@arndb.de>, minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ipmi: avoid gcc warning
Date: Wed, 28 Jan 2015 10:46:21 -0600 [thread overview]
Message-ID: <54C9125D.5040706@mvista.com> (raw)
In-Reply-To: <2457592.UIVPJ2WNL3@wuerfel>
Thanks, queued for 3.20.
-corey
On 01/28/2015 09:00 AM, Arnd Bergmann wrote:
> A new harmless warning has come up on ARM builds with gcc-4.9:
>
> drivers/char/ipmi/ipmi_msghandler.c: In function 'smi_send.isra.11':
> include/linux/spinlock.h:372:95: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
> raw_spin_unlock_irqrestore(&lock->rlock, flags);
> ^
> drivers/char/ipmi/ipmi_msghandler.c:1490:16: note: 'flags' was declared here
> unsigned long flags;
> ^
>
> This could be worked around by initializing the 'flags' variable, but it
> seems better to rework the code to avoid this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7ea0ed2b5be81 ("ipmi: Make the message handler easier to use for SMI interfaces")
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 6b65fa4e0c55..fb0f8eacd208 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -1483,14 +1483,10 @@ static inline void format_lan_msg(struct ipmi_smi_msg *smi_msg,
> smi_msg->msgid = msgid;
> }
>
> -static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> - struct ipmi_smi_msg *smi_msg, int priority)
> +static struct ipmi_smi_msg *smi_add_send_msg(ipmi_smi_t intf,
> + struct ipmi_smi_msg *smi_msg,
> + int priority)
> {
> - int run_to_completion = intf->run_to_completion;
> - unsigned long flags;
> -
> - if (!run_to_completion)
> - spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
> if (intf->curr_msg) {
> if (priority > 0)
> list_add_tail(&smi_msg->link, &intf->hp_xmit_msgs);
> @@ -1500,8 +1496,24 @@ static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> } else {
> intf->curr_msg = smi_msg;
> }
> - if (!run_to_completion)
> +
> + return smi_msg;
> +}
> +
> +
> +static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
> + struct ipmi_smi_msg *smi_msg, int priority)
> +{
> + int run_to_completion = intf->run_to_completion;
> +
> + if (run_to_completion) {
> + smi_msg = smi_add_send_msg(intf, smi_msg, priority);
> + } else {
> + unsigned long flags;
> + spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
> + smi_msg = smi_add_send_msg(intf, smi_msg, priority);
> spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
> + }
>
> if (smi_msg)
> handlers->sender(intf->send_info, smi_msg);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-01-28 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 15:00 [PATCH] ipmi: avoid gcc warning Arnd Bergmann
2015-01-28 15:00 ` Arnd Bergmann
2015-01-28 16:46 ` Corey Minyard [this message]
2015-01-28 16:46 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C9125D.5040706@mvista.com \
--to=cminyard@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.