From: Guenter Roeck <linux@roeck-us.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: split up mm_struct to separate header file
Date: Wed, 28 Jan 2015 20:22:28 -0800 [thread overview]
Message-ID: <54C9B584.6060302@roeck-us.net> (raw)
In-Reply-To: <20150129003028.GA17519@node.dhcp.inet.fi>
On 01/28/2015 04:30 PM, Kirill A. Shutemov wrote:
> On Wed, Jan 28, 2015 at 03:17:42PM +0200, Kirill A. Shutemov wrote:
>> We want to use __PAGETABLE_PMD_FOLDED in mm_struct to drop nr_pmds if
>> pmd is folded. __PAGETABLE_PMD_FOLDED is defined in <asm/pgtable.h>, but
>> <asm/pgtable.h> itself wants <linux/mm_types.h> for struct page
>> definition.
>>
>> This patch move mm_struct definition into separate header file in order
>> to fix circular header dependencies.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Guenter, below is update for the patch. It doesn't fix all the issues, but
> you should see an improvement. I'll continue with this tomorrow.
Yes, this is much better than before.
Build results:
total: 134 pass: 122 fail: 12
Failed builds:
arm:imx_v6_v7_defconfig
arm:s3c6400_defconfig
cris:artpec_3_defconfig
cris:etraxfs_defconfig
hexagon:defconfig
m68k:m5475evb_defconfig
mips:allmodconfig
s390:defconfig
sparc64:defconfig
sparc64:allmodconfig
unicore32:defconfig
xtensa:allmodconfig
Qemu tests:
total: 30 pass: 28 fail: 2
Failed tests:
sparc64:sparc_smp_defconfig
sparc64:sparc_nosmp_defconfig
Some of the problems are inherited from mmotm.
Here are the mmotm build results (v3.19-rc6-462-g995c249):
total: 134 pass: 128 fail: 6
Failed builds:
arm:imx_v6_v7_defconfig
arm:s3c6400_defconfig
mips:allmodconfig
sparc64:allmodconfig
unicore32:defconfig
xtensa:allmodconfig
Qemu tests:
total: 30 pass: 30 fail: 0
With this, we can conclude that your patch series still has problems
(at least) with cris, hexagon, m68k, s390, sparc, and unicore32.
Guenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: split up mm_struct to separate header file
Date: Wed, 28 Jan 2015 20:22:28 -0800 [thread overview]
Message-ID: <54C9B584.6060302@roeck-us.net> (raw)
In-Reply-To: <20150129003028.GA17519@node.dhcp.inet.fi>
On 01/28/2015 04:30 PM, Kirill A. Shutemov wrote:
> On Wed, Jan 28, 2015 at 03:17:42PM +0200, Kirill A. Shutemov wrote:
>> We want to use __PAGETABLE_PMD_FOLDED in mm_struct to drop nr_pmds if
>> pmd is folded. __PAGETABLE_PMD_FOLDED is defined in <asm/pgtable.h>, but
>> <asm/pgtable.h> itself wants <linux/mm_types.h> for struct page
>> definition.
>>
>> This patch move mm_struct definition into separate header file in order
>> to fix circular header dependencies.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Guenter, below is update for the patch. It doesn't fix all the issues, but
> you should see an improvement. I'll continue with this tomorrow.
Yes, this is much better than before.
Build results:
total: 134 pass: 122 fail: 12
Failed builds:
arm:imx_v6_v7_defconfig
arm:s3c6400_defconfig
cris:artpec_3_defconfig
cris:etraxfs_defconfig
hexagon:defconfig
m68k:m5475evb_defconfig
mips:allmodconfig
s390:defconfig
sparc64:defconfig
sparc64:allmodconfig
unicore32:defconfig
xtensa:allmodconfig
Qemu tests:
total: 30 pass: 28 fail: 2
Failed tests:
sparc64:sparc_smp_defconfig
sparc64:sparc_nosmp_defconfig
Some of the problems are inherited from mmotm.
Here are the mmotm build results (v3.19-rc6-462-g995c249):
total: 134 pass: 128 fail: 6
Failed builds:
arm:imx_v6_v7_defconfig
arm:s3c6400_defconfig
mips:allmodconfig
sparc64:allmodconfig
unicore32:defconfig
xtensa:allmodconfig
Qemu tests:
total: 30 pass: 30 fail: 0
With this, we can conclude that your patch series still has problems
(at least) with cris, hexagon, m68k, s390, sparc, and unicore32.
Guenter
next prev parent reply other threads:[~2015-01-29 4:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:17 [PATCH 0/4] Introduce <linux/mm_struct.h> Kirill A. Shutemov
2015-01-28 13:17 ` Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 1/4] mm: move enum tlb_flush_reason into <trace/events/tlb.h> Kirill A. Shutemov
2015-01-28 13:17 ` Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 2/4] mm: split up mm_struct to separate header file Kirill A. Shutemov
2015-01-28 13:17 ` Kirill A. Shutemov
2015-01-29 0:30 ` Kirill A. Shutemov
2015-01-29 0:30 ` Kirill A. Shutemov
2015-01-29 2:02 ` Guenter Roeck
2015-01-29 2:02 ` Guenter Roeck
2015-01-29 4:22 ` Guenter Roeck [this message]
2015-01-29 4:22 ` Guenter Roeck
2015-01-28 13:17 ` [PATCH 3/4] mm: define __PAGETABLE_{PMD,PUD}_FOLDED to zero or one Kirill A. Shutemov
2015-01-28 13:17 ` Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 4/4] mm: do not add nr_pmds into mm_struct if PMD is folded Kirill A. Shutemov
2015-01-28 13:17 ` Kirill A. Shutemov
2015-01-28 17:06 ` [PATCH 0/4] Introduce <linux/mm_struct.h> Guenter Roeck
2015-01-28 17:06 ` Guenter Roeck
2015-01-28 18:50 ` Guenter Roeck
2015-01-28 18:50 ` Guenter Roeck
2015-01-28 20:45 ` Kirill A. Shutemov
2015-01-28 20:45 ` Kirill A. Shutemov
2015-01-28 21:18 ` Guenter Roeck
2015-01-28 21:18 ` Guenter Roeck
2015-01-28 21:16 ` Kirill A. Shutemov
2015-01-28 21:16 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C9B584.6060302@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.