mSHEC pull request (2nd challenge)

mSHEC pull request (2nd challenge)

[Miyamae, Takeshi]

Hi Loic,

When I reset our commits on our fork repository, the 1st pull request was automatically closed.
So, I have issued another pull request of mSHEC.

mSHEC : multiple Shingled Erasure Code #3534
https://github.com/ceph/ceph/pull/3534

As a result, I believe I have squashed our commits into one.
I'm grad if you could restart the review.

(You already noticed that and gave us labels, thank you!)

Best regards,
Takeshi Miyamae

Re: mSHEC pull request (2nd challenge)

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Hi,

It looks good and ready for integration testing :-) I just created http://tracker.ceph.com/issues/10686 to track this feature. Since we are late in development cycle and unless someone has a different opinion, I will mark the SHEC plugin as experimental so people know it's new. I will however do that after it is merged in master.

Cheers

On 29/01/2015 15:24, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> When I reset our commits on our fork repository, the 1st pull request was automatically closed.
> So, I have issued another pull request of mSHEC.
> 
> mSHEC : multiple Shingled Erasure Code #3534
> https://github.com/ceph/ceph/pull/3534
> 
> As a result, I believe I have squashed our commits into one.
> I'm grad if you could restart the review.
> 
> (You already noticed that and gave us labels, thank you!)
> 
> Best regards,
> Takeshi Miyamae
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

RE: mSHEC pull request (2nd challenge)

[Miyamae, Takeshi]

Hi Loic,

Thank you for your cooperation !
If we could do something to reduce your burdens, please let us know.

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Thursday, January 29, 2015 11:38 PM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Kawaguchi, Shotaro/川口 翔太朗; Kaga, Yoshihiro/加賀 芳宏; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com)
Subject: Re: mSHEC pull request (2nd challenge)

Hi,

It looks good and ready for integration testing :-) I just created http://tracker.ceph.com/issues/10686 to track this feature. Since we are late in development cycle and unless someone has a different opinion, I will mark the SHEC plugin as experimental so people know it's new. I will however do that after it is merged in master.

Cheers

On 29/01/2015 15:24, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> When I reset our commits on our fork repository, the 1st pull request was automatically closed.
> So, I have issued another pull request of mSHEC.
> 
> mSHEC : multiple Shingled Erasure Code #3534
> https://github.com/ceph/ceph/pull/3534
> 
> As a result, I believe I have squashed our commits into one.
> I'm grad if you could restart the review.
> 
> (You already noticed that and gave us labels, thank you!)
> 
> Best regards,
> Takeshi Miyamae
> 

-- 
Loïc Dachary, Artisan Logiciel Libre

Re: mSHEC pull request (2nd challenge)

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]


Hi,

On 30/01/2015 11:28, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> Thank you for your cooperation !
> If we could do something to reduce your burdens, please let us know.

Hopefully tests come out clean, let see :-)

There was originally two files for tests and the one with 364 or something at the end was removed if I'm not mistaken. Is there a reason for that ?

Cheers

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Thursday, January 29, 2015 11:38 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Kawaguchi, Shotaro/川口 翔太朗; Kaga, Yoshihiro/加賀 芳宏; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com)
> Subject: Re: mSHEC pull request (2nd challenge)
> 
> Hi,
> 
> It looks good and ready for integration testing :-) I just created http://tracker.ceph.com/issues/10686 to track this feature. Since we are late in development cycle and unless someone has a different opinion, I will mark the SHEC plugin as experimental so people know it's new. I will however do that after it is merged in master.
> 
> Cheers
> 
> On 29/01/2015 15:24, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> When I reset our commits on our fork repository, the 1st pull request was automatically closed.
>> So, I have issued another pull request of mSHEC.
>>
>> mSHEC : multiple Shingled Erasure Code #3534
>> https://github.com/ceph/ceph/pull/3534
>>
>> As a result, I believe I have squashed our commits into one.
>> I'm grad if you could restart the review.
>>
>> (You already noticed that and gave us labels, thank you!)
>>
>> Best regards,
>> Takeshi Miyamae
>>
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

RE: mSHEC pull request (2nd challenge)

[Miyamae, Takeshi]

Hi Loic,

> There was originally two files for tests and the one with 364 or something at the end was removed
> if I'm not mistaken. Is there a reason for that ?

We had renamed the file from TestErasureCodeShec364.cc to TestErasureCodeShec_all.cc
because the number of tests included in this file is not always just 364. It's a simple reason. (^^)

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Friday, January 30, 2015 8:29 PM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Kawaguchi, Shotaro/川口 翔太朗; Kaga, Yoshihiro/加賀 芳宏; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com)
Subject: Re: mSHEC pull request (2nd challenge)


Hi,

On 30/01/2015 11:28, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> Thank you for your cooperation !
> If we could do something to reduce your burdens, please let us know.

Hopefully tests come out clean, let see :-)

There was originally two files for tests and the one with 364 or something at the end was removed if I'm not mistaken. Is there a reason for that ?

Cheers

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Thursday, January 29, 2015 11:38 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Kawaguchi, Shotaro/川口 翔太朗; Kaga, Yoshihiro/加賀 芳宏; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com)
> Subject: Re: mSHEC pull request (2nd challenge)
> 
> Hi,
> 
> It looks good and ready for integration testing :-) I just created http://tracker.ceph.com/issues/10686 to track this feature. Since we are late in development cycle and unless someone has a different opinion, I will mark the SHEC plugin as experimental so people know it's new. I will however do that after it is merged in master.
> 
> Cheers
> 
> On 29/01/2015 15:24, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> When I reset our commits on our fork repository, the 1st pull request was automatically closed.
>> So, I have issued another pull request of mSHEC.
>>
>> mSHEC : multiple Shingled Erasure Code #3534
>> https://github.com/ceph/ceph/pull/3534
>>
>> As a result, I believe I have squashed our commits into one.
>> I'm grad if you could restart the review.
>>
>> (You already noticed that and gave us labels, thank you!)
>>
>> Best regards,
>> Takeshi Miyamae
>>
> 

-- 
Loïc Dachary, Artisan Logiciel Libre