From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-sockets: Fix buffer overflow in inet_parse()
Date: Fri, 30 Jan 2015 15:06:13 -0500 [thread overview]
Message-ID: <54CBE435.9090409@redhat.com> (raw)
In-Reply-To: <1422646675-17657-1-git-send-email-kwolf@redhat.com>
On 01/30/2015 02:37 PM, Kevin Wolf wrote:
> The size of the stack allocated host[] array didn't account for the
> terminating '\0' byte that sscanf() writes. Fix the array size.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> util/qemu-sockets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index a76bb3c..aacf1fc 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -512,7 +512,7 @@ InetSocketAddress *inet_parse(const char *str, Error **errp)
> {
> InetSocketAddress *addr;
> const char *optstr, *h;
> - char host[64];
> + char host[65];
> char port[33];
> int to;
> int pos;
>
You don't really need reviews for trivial, right?
*shrug*
Reviewed-by: John Snow <jsnow@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-sockets: Fix buffer overflow in inet_parse()
Date: Fri, 30 Jan 2015 15:06:13 -0500 [thread overview]
Message-ID: <54CBE435.9090409@redhat.com> (raw)
In-Reply-To: <1422646675-17657-1-git-send-email-kwolf@redhat.com>
On 01/30/2015 02:37 PM, Kevin Wolf wrote:
> The size of the stack allocated host[] array didn't account for the
> terminating '\0' byte that sscanf() writes. Fix the array size.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> util/qemu-sockets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index a76bb3c..aacf1fc 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -512,7 +512,7 @@ InetSocketAddress *inet_parse(const char *str, Error **errp)
> {
> InetSocketAddress *addr;
> const char *optstr, *h;
> - char host[64];
> + char host[65];
> char port[33];
> int to;
> int pos;
>
You don't really need reviews for trivial, right?
*shrug*
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-01-30 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 19:37 [Qemu-trivial] [PATCH] qemu-sockets: Fix buffer overflow in inet_parse() Kevin Wolf
2015-01-30 19:37 ` [Qemu-devel] " Kevin Wolf
2015-01-30 20:06 ` John Snow [this message]
2015-01-30 20:06 ` John Snow
2015-02-07 9:08 ` [Qemu-trivial] " Michael Tokarev
2015-02-07 9:08 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBE435.9090409@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.