* linux-next: libahci_platform has undefined symbol on sparc
@ 2015-01-31 13:14 ` Yann Droneaud
0 siblings, 0 replies; 6+ messages in thread
From: Yann Droneaud @ 2015-01-31 13:14 UTC (permalink / raw)
To: Gregory CLEMENT, Tejun Heo
Cc: linux-next, linux-ide, sparclinux, Yann Droneaud
Hi,
I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0
("ata: libahci: Allow using multiple regulators") from linux-next:
This commit modify ahci_platform_get_resources to use of_platform_device_create().
Unfortunately, it seems that of_platform_device_create() is not
available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc,
the module libahci_platform.ko is rejected by modpost:
ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!
../scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[2]: *** [__modpost] Error 1
src/linux/Makefile:1120: recipe for target 'modules' failed
Regards.
--
Yann Droneaud
OPTEYA
^ permalink raw reply [flat|nested] 6+ messages in thread* linux-next: libahci_platform has undefined symbol on sparc @ 2015-01-31 13:14 ` Yann Droneaud 0 siblings, 0 replies; 6+ messages in thread From: Yann Droneaud @ 2015-01-31 13:14 UTC (permalink / raw) To: Gregory CLEMENT, Tejun Heo Cc: linux-next, linux-ide, sparclinux, Yann Droneaud Hi, I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow using multiple regulators") from linux-next: This commit modify ahci_platform_get_resources to use of_platform_device_create(). Unfortunately, it seems that of_platform_device_create() is not available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc, the module libahci_platform.ko is rejected by modpost: ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[2]: *** [__modpost] Error 1 src/linux/Makefile:1120: recipe for target 'modules' failed Regards. -- Yann Droneaud OPTEYA ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: libahci_platform has undefined symbol on sparc 2015-01-31 13:14 ` Yann Droneaud @ 2015-01-31 16:25 ` Hans de Goede -1 siblings, 0 replies; 6+ messages in thread From: Hans de Goede @ 2015-01-31 16:25 UTC (permalink / raw) To: Yann Droneaud, Gregory CLEMENT, Tejun Heo Cc: linux-next, linux-ide, sparclinux Hi, On 01/31/2015 02:14 PM, Yann Droneaud wrote: > Hi, > > I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 > ("ata: libahci: Allow using multiple regulators") from linux-next: > This commit modify ahci_platform_get_resources to use of_platform_device_create(). > > Unfortunately, it seems that of_platform_device_create() is not > available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc, > the module libahci_platform.ko is rejected by modpost: > > ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! > ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[2]: *** [__modpost] Error 1 > src/linux/Makefile:1120: recipe for target 'modules' failed Ah yes we had the same problem in simplefb, the example code for using of_platform_device came from simplefb, and already had the fix, but it look like Gregory did not include the bits fixing this in the ahci_platform code Gregory, can you please submit a follow up patch fixing this? See simplefb.c for the easiest way to fix this. Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: libahci_platform has undefined symbol on sparc @ 2015-01-31 16:25 ` Hans de Goede 0 siblings, 0 replies; 6+ messages in thread From: Hans de Goede @ 2015-01-31 16:25 UTC (permalink / raw) To: Yann Droneaud, Gregory CLEMENT, Tejun Heo Cc: linux-next, linux-ide, sparclinux Hi, On 01/31/2015 02:14 PM, Yann Droneaud wrote: > Hi, > > I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 > ("ata: libahci: Allow using multiple regulators") from linux-next: > This commit modify ahci_platform_get_resources to use of_platform_device_create(). > > Unfortunately, it seems that of_platform_device_create() is not > available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc, > the module libahci_platform.ko is rejected by modpost: > > ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! > ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[2]: *** [__modpost] Error 1 > src/linux/Makefile:1120: recipe for target 'modules' failed Ah yes we had the same problem in simplefb, the example code for using of_platform_device came from simplefb, and already had the fix, but it look like Gregory did not include the bits fixing this in the ahci_platform code Gregory, can you please submit a follow up patch fixing this? See simplefb.c for the easiest way to fix this. Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: libahci_platform has undefined symbol on sparc 2015-01-31 16:25 ` Hans de Goede @ 2015-01-31 16:38 ` Gregory CLEMENT -1 siblings, 0 replies; 6+ messages in thread From: Gregory CLEMENT @ 2015-01-31 16:38 UTC (permalink / raw) To: Hans de Goede, Yann Droneaud, Tejun Heo; +Cc: linux-next, linux-ide, sparclinux Hi Hans, On 31/01/2015 17:25, Hans de Goede wrote: > Hi, > > On 01/31/2015 02:14 PM, Yann Droneaud wrote: >> Hi, >> >> I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 >> ("ata: libahci: Allow using multiple regulators") from linux-next: >> This commit modify ahci_platform_get_resources to use of_platform_device_create(). >> >> Unfortunately, it seems that of_platform_device_create() is not >> available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc, >> the module libahci_platform.ko is rejected by modpost: >> >> ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! >> ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed >> make[2]: *** [__modpost] Error 1 >> src/linux/Makefile:1120: recipe for target 'modules' failed > > Ah yes we had the same problem in simplefb, the example code for using > of_platform_device came from simplefb, and already had the fix, but it look > like Gregory did not include the bits fixing this in the ahci_platform code > > Gregory, can you please submit a follow up patch fixing this? See simplefb.c > for the easiest way to fix this. I could but Guenter already sent it :) Gregory > > Regards, > > Hans > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: libahci_platform has undefined symbol on sparc @ 2015-01-31 16:38 ` Gregory CLEMENT 0 siblings, 0 replies; 6+ messages in thread From: Gregory CLEMENT @ 2015-01-31 16:38 UTC (permalink / raw) To: Hans de Goede, Yann Droneaud, Tejun Heo; +Cc: linux-next, linux-ide, sparclinux Hi Hans, On 31/01/2015 17:25, Hans de Goede wrote: > Hi, > > On 01/31/2015 02:14 PM, Yann Droneaud wrote: >> Hi, >> >> I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 >> ("ata: libahci: Allow using multiple regulators") from linux-next: >> This commit modify ahci_platform_get_resources to use of_platform_device_create(). >> >> Unfortunately, it seems that of_platform_device_create() is not >> available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc, >> the module libahci_platform.ko is rejected by modpost: >> >> ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! >> ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed >> make[2]: *** [__modpost] Error 1 >> src/linux/Makefile:1120: recipe for target 'modules' failed > > Ah yes we had the same problem in simplefb, the example code for using > of_platform_device came from simplefb, and already had the fix, but it look > like Gregory did not include the bits fixing this in the ahci_platform code > > Gregory, can you please submit a follow up patch fixing this? See simplefb.c > for the easiest way to fix this. I could but Guenter already sent it :) Gregory > > Regards, > > Hans > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-31 16:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-31 13:14 linux-next: libahci_platform has undefined symbol on sparc Yann Droneaud 2015-01-31 13:14 ` Yann Droneaud 2015-01-31 16:25 ` Hans de Goede 2015-01-31 16:25 ` Hans de Goede 2015-01-31 16:38 ` Gregory CLEMENT 2015-01-31 16:38 ` Gregory CLEMENT
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.