Re: [PATCH] staging: vt6655: dpc: Removed variables that is never used

[Malcolm Priestley <tvboxspy@gmail.com>]

On 31/01/15 15:16, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/vt6655/dpc.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
> index 977683c..9e9da3c 100644
> --- a/drivers/staging/vt6655/dpc.c
> +++ b/drivers/staging/vt6655/dpc.c
> @@ -43,7 +43,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
>   	struct ieee80211_rx_status rx_status = { 0 };
>   	struct ieee80211_hdr *hdr;
>   	__le16 fc;
> -	u8 *rsr, *new_rsr, *rssi;
> +	u8 *rssi;
I rather this was not removed, these are error reporting.

I have a patch for them that I will send shortly.


Malcolm


>   	__le64 *tsf_time;
>   	u16 frame_size;
>   	int ii, r;
> @@ -88,9 +88,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
>
>   	tsf_time = (__le64 *)(skb_data + bytes_received - 12);
>   	sq = skb_data + bytes_received - 4;
> -	new_rsr = skb_data + bytes_received - 3;
>   	rssi = skb_data + bytes_received - 2;
> -	rsr = skb_data + bytes_received - 1;
>
>   	RFvRSSITodBm(priv, *rssi, &rx_dbm);
>
>