From: Laxman Dewangan <ldewangan@nvidia.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling
Date: Mon, 2 Feb 2015 14:45:28 +0530 [thread overview]
Message-ID: <54CF4030.5080407@nvidia.com> (raw)
In-Reply-To: <20150202090809.GB19706@opentech.at>
On Monday 02 February 2015 02:38 PM, Nicholas Mc Guire wrote:
> On Mon, 02 Feb 2015, Laxman Dewangan wrote:
>
>>
>>> + if (WARN_ON(dma_timeout == 0)) {
>>> dev_err(tsd->dev,
>>> - "spi trasfer timeout, err %d\n", ret);
>>> + "spi trasfer timeout\n");
>> trasfer -> transfer.
>>
>>
> overlooked that - sorry - will fix it up and resubmit.
>
Thanks, And possibly we will be able to merge two lines into single one
i.e. single line error message.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>, <linux-spi@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling
Date: Mon, 2 Feb 2015 14:45:28 +0530 [thread overview]
Message-ID: <54CF4030.5080407@nvidia.com> (raw)
In-Reply-To: <20150202090809.GB19706@opentech.at>
On Monday 02 February 2015 02:38 PM, Nicholas Mc Guire wrote:
> On Mon, 02 Feb 2015, Laxman Dewangan wrote:
>
>>
>>> + if (WARN_ON(dma_timeout == 0)) {
>>> dev_err(tsd->dev,
>>> - "spi trasfer timeout, err %d\n", ret);
>>> + "spi trasfer timeout\n");
>> trasfer -> transfer.
>>
>>
> overlooked that - sorry - will fix it up and resubmit.
>
Thanks, And possibly we will be able to merge two lines into single one
i.e. single line error message.
next prev parent reply other threads:[~2015-02-02 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 13:00 [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling Nicholas Mc Guire
2015-02-01 13:00 ` Nicholas Mc Guire
2015-02-02 9:00 ` Laxman Dewangan
2015-02-02 9:00 ` Laxman Dewangan
[not found] ` <54CF3CC5.6030204-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-02-02 9:08 ` Nicholas Mc Guire
2015-02-02 9:08 ` Nicholas Mc Guire
2015-02-02 9:15 ` Laxman Dewangan [this message]
2015-02-02 9:15 ` Laxman Dewangan
-- strict thread matches above, loose matches on Subject: below --
2015-02-01 13:00 Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF4030.5080407@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=der.herr@hofr.at \
--cc=gnurou@gmail.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.