All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: tlv320aic3x: Fix data delay configuration
@ 2015-02-02  8:20 Peter Ujfalusi
  2015-02-02 11:58 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Ujfalusi @ 2015-02-02  8:20 UTC (permalink / raw)
  To: Mark Brown, tiwai; +Cc: pavel, alsa-devel, Liam Girdwood, Jarkko Nikula

The CTRLC register were not receiving the correct delay configuration,
which will corrupt DSP_A audio mode.

Fixes: 368494093354 ("ASoC: tlv320aic3x: Add TDM support")

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
---

Changes since v1:
Fixes tag and Tested-by from Pavel and Jarkko added to commit message.

Regards,
Peter

 sound/soc/codecs/tlv320aic3x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index a78ad361f494..07603d142923 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1046,7 +1046,7 @@ static int aic3x_prepare(struct snd_pcm_substream *substream,
 		delay += aic3x->tdm_delay;
 
 	/* Configure data delay */
-	snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, aic3x->tdm_delay);
+	snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, delay);
 
 	return 0;
 }
-- 
2.2.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ASoC: tlv320aic3x: Fix data delay configuration
  2015-02-02  8:20 [PATCH v2] ASoC: tlv320aic3x: Fix data delay configuration Peter Ujfalusi
@ 2015-02-02 11:58 ` Mark Brown
  2015-02-02 12:50   ` Peter Ujfalusi
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2015-02-02 11:58 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: tiwai, alsa-devel, pavel, Liam Girdwood, Jarkko Nikula


[-- Attachment #1.1: Type: text/plain, Size: 269 bytes --]

On Mon, Feb 02, 2015 at 10:20:23AM +0200, Peter Ujfalusi wrote:

> Changes since v1:
> Fixes tag and Tested-by from Pavel and Jarkko added to commit message.

If there are any code changes from the version I've already applied
please send them as an incremental patch.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ASoC: tlv320aic3x: Fix data delay configuration
  2015-02-02 11:58 ` Mark Brown
@ 2015-02-02 12:50   ` Peter Ujfalusi
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2015-02-02 12:50 UTC (permalink / raw)
  To: Mark Brown; +Cc: tiwai, alsa-devel, pavel, Liam Girdwood, Jarkko Nikula

On 02/02/2015 01:58 PM, Mark Brown wrote:
> On Mon, Feb 02, 2015 at 10:20:23AM +0200, Peter Ujfalusi wrote:
> 
>> Changes since v1:
>> Fixes tag and Tested-by from Pavel and Jarkko added to commit message.
> 
> If there are any code changes from the version I've already applied
> please send them as an incremental patch.

No change to the code, just commit message.

Thanks,
Péter

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-02 12:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-02  8:20 [PATCH v2] ASoC: tlv320aic3x: Fix data delay configuration Peter Ujfalusi
2015-02-02 11:58 ` Mark Brown
2015-02-02 12:50   ` Peter Ujfalusi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.