From: Julien Grall <julien.grall@linaro.org>
To: David Vrabel <david.vrabel@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: rcu_sched self-detect stall when disable vif device
Date: Mon, 02 Feb 2015 13:54:52 +0000 [thread overview]
Message-ID: <54CF81AC.1070400@linaro.org> (raw)
In-Reply-To: <54CBAB75.1080301@citrix.com>
Hi David,
On 30/01/15 16:04, David Vrabel wrote:
> How about this?
This is working for me. Thanks!
> 8<------------------------------------------
> xen-netback: stop the guest rx thread after a fatal error
>
> After commit e9d8b2c2968499c1f96563e6522c56958d5a1d0d (xen-netback:
> disable rogue vif in kthread context), a fatal (protocol) error would
> leave the guest Rx thread spinning, wasting CPU time. Commit
> ecf08d2dbb96d5a4b4bcc53a39e8d29cc8fef02e (xen-netback: reintroduce
> guest Rx stall detection) made this even worse by removing a
> cond_resched() from this path.
>
> A fatal error is non-recoverable so just allow the guest Rx thread to
> exit. This requires taking additional refs to the task so the thread
> exiting early is handled safely.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reported-by: Julien Grall <julien.grall@linaro.org>
Tested-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-02-02 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 16:03 rcu_sched self-detect stall when disable vif device Julien Grall
2015-01-27 16:45 ` Wei Liu
2015-01-27 16:47 ` Julien Grall
2015-01-27 16:53 ` Wei Liu
2015-01-28 16:45 ` Julien Grall
2015-01-28 17:06 ` David Vrabel
2015-01-28 17:27 ` Julien Grall
2015-01-30 16:04 ` David Vrabel
2015-02-02 13:54 ` Julien Grall [this message]
2015-01-27 16:56 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF81AC.1070400@linaro.org \
--to=julien.grall@linaro.org \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.