Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

[Bryan O'Donoghue]

Hi guys.

Has the issue with PVM masking been addressed ?

https://lkml.org/lkml/2014/10/1/221

If not then please drop MSIs from this patchset.

--
Bryan

Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

[Andy Shevchenko]

On Mon, 2015-02-02 at 15:17 +0000, Bryan O'Donoghue wrote:
> Hi guys.
> 
> Has the issue with PVM masking been addressed ?
> 
> https://lkml.org/lkml/2014/10/1/221
> 
> If not then please drop MSIs from this patchset.

I do not see the reason why it should be done on per driver basis.
Care to fix this under arch/x86 then when adding new Quark platform?

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy

Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

[Bryan O'Donoghue]

On 02/02/15 15:46, Andy Shevchenko wrote:
> On Mon, 2015-02-02 at 15:17 +0000, Bryan O'Donoghue wrote:
>> Hi guys.
>>
>> Has the issue with PVM masking been addressed ?
>>
>> https://lkml.org/lkml/2014/10/1/221
>>
>> If not then please drop MSIs from this patchset.
>
> I do not see the reason why it should be done on per driver basis.

Agree.

> Care to fix this under arch/x86 then when adding new Quark platform?

Looking into that now.

Hmm - OK -let's aim to get a fix in for the bridge and leave the MSI 
enable in place.

RE: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

[Kweh, Hock Leong]

> -----Original Message-----
> From: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie]
> Sent: Monday, February 02, 2015 11:50 PM
> To: Andy Shevchenko
> Cc: netdev@vger.kernel.org; Kweh, Hock Leong; davem@davemloft.net;
> Ahmad, Josef
> Subject: Re: [PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark
> X1000
> 
> On 02/02/15 15:46, Andy Shevchenko wrote:
> > On Mon, 2015-02-02 at 15:17 +0000, Bryan O'Donoghue wrote:
> > > Hi guys.
> > >
> > > Has the issue with PVM masking been addressed ?
> > >
> > > https://lkml.org/lkml/2014/10/1/221
> > >
> > > If not then please drop MSIs from this patchset.
> >
> > I do not see the reason why it should be done on per driver basis.
> 
> Agree.
> 
> > Care to fix this under arch/x86 then when adding new Quark platform?
> 
> Looking into that now.
> 
> Hmm - OK -let's aim to get a fix in for the bridge and leave the MSI enable in
> place.
> 

I am also agreeing on that. Thanks.

Regards,
Wilson

[PATCH v3 0/3] net: stmmac: Enable Intel Quark SoC X1000 Ethernet support

[Andy Shevchenko]

This is third version of the patch series [1] to bring network card support to
Intel Quark SoC.

The series has been tested on Intel Galileo board.

Changelog v3:
 - rebase on top of recent net-next
 - rework an approach to get the custom configuration
 - rework an approach how to get unique bus_id
 - improve DMI lookup function

[1] http://www.spinics.net/lists/netdev/msg296010.html

Andy Shevchenko (1):
  stmmac: pci: introduce Intel Quark X1000 runtime detection

Kweh, Hock Leong (2):
  stmmac: pci: add support for Intel Quark X1000
  stmmac: pci: add MSI support for Intel Quark X1000

 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 113 ++++++++++++++++++++++-
 1 file changed, 112 insertions(+), 1 deletion(-)

-- 
2.1.4

[PATCH v3 3/3] stmmac: pci: add MSI support for Intel Quark X1000

[Andy Shevchenko]

From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>

In Intel Quark SoC X1000, both of the Ethernet controllers support
MSI interrupt handling. This patch enables them to use MSI interrupt
servicing in stmmac_pci for Intel Quark X1000.

Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
index 50f3c50..3bca908 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
@@ -212,6 +212,8 @@ static int stmmac_pci_probe(struct pci_dev *pdev,
 	} else
 		stmmac_default_data(plat);
 
+	pci_enable_msi(pdev);
+
 	priv = stmmac_dvr_probe(&pdev->dev, plat, pcim_iomap_table(pdev)[i]);
 	if (IS_ERR(priv)) {
 		dev_err(&pdev->dev, "%s: main driver probe failed\n", __func__);
-- 
2.1.4