All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, David Vrabel <david.vrabel@citrix.com>,
	Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/devicetree: Fix build for amd64
Date: Tue, 03 Feb 2015 00:14:14 +0800	[thread overview]
Message-ID: <54CFA256.5010106@linux.intel.com> (raw)
In-Reply-To: <1422892230-28328-1-git-send-email-ricardo.ribalda@gmail.com>

Hi Ricardo,
	How about defining a version of apic_force_enable()
for X86_64 in apic.h which just return failure?
Regards!
Gerry

On 2015/2/2 23:50, Ricardo Ribalda Delgado wrote:
> apic_force_enable is not defined for amd64.
> 
> Without this patch:
> 
> LD      init/built-in.o
> arch/x86/built-in.o: In function `dtb_lapic_setup':
> kernel/devicetree.c:155:
> undefined reference to `apic_force_enable'
> Makefile:923: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  arch/x86/kernel/devicetree.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 3d35033..b5560de 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void)
>  
>  	/* Did the boot loader setup the local APIC ? */
>  	if (!cpu_has_apic) {
> +#ifndef CONFIG_X86_64
>  		if (apic_force_enable(r.start))
> +#endif
>  			return;
>  	}
>  	smp_found_config = 1;
> 

  reply	other threads:[~2015-02-02 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 15:50 [PATCH] x86/devicetree: Fix build for amd64 Ricardo Ribalda Delgado
2015-02-02 16:14 ` Jiang Liu [this message]
2015-02-02 16:17   ` Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CFA256.5010106@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ricardo.ribalda@gmail.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.