All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: ell@lists.01.org
Subject: Re: [RFC 0/2] Cipher infrastructure
Date: Tue, 03 Feb 2015 10:07:51 +0200	[thread overview]
Message-ID: <54D081D7.2050503@linux.intel.com> (raw)
In-Reply-To: <54CFC579.9050805@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi Denis,

> Hi Tomasz,
>
> On 01/30/2015 04:57 AM, Tomasz Bursztyka wrote:
>> Hi,
>>
>> Went quickly through the cipher proposal, to get a somehow working 
>> implementation.
>> Seems to work with aes, but not with arc4.
>>
>
> ARC4 is a bit weird.  The same function is used for encryption and 
> decryption, so the stream is not reset.  You will likely need to set 
> the key prior to each encrypt/decrypt operation.

OK.

>
>> And now I wonder if we should not provide an initialization vector 
>> for some ciphers? (like arc4).
>>
>
> I'm still not fully sure we need the IV.  EAPoL Key-IV is only used in 
> certain situations.  Lets try to find an AP / trace that actually sets 
> the IV field.
>

Ok, then I think it's worth putting an iv/iv-len params to the 
l_cipher_new(). I might implement its support later though, let's see 
(but at least the API would be fixed).

Tomasz

      reply	other threads:[~2015-02-03  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 10:57 [RFC 0/2] Cipher infrastructure Tomasz Bursztyka
2015-01-30 10:57 ` [PATCH 1/2] cipher: Add a basic infrastructure for kernel based cipher operations Tomasz Bursztyka
2015-01-30 10:57 ` [PATCH 2/2] unit: Add unit test for the cipher infrastructure Tomasz Bursztyka
2015-02-02 18:44 ` [RFC 0/2] Cipher infrastructure Denis Kenzior
2015-02-03  8:07   ` Tomasz Bursztyka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D081D7.2050503@linux.intel.com \
    --to=tomasz.bursztyka@linux.intel.com \
    --cc=ell@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.