From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters
Date: Tue, 03 Feb 2015 09:52:31 +0100 [thread overview]
Message-ID: <54D08C4F.5050705@redhat.com> (raw)
In-Reply-To: <54CFE7A2.2090304@redhat.com>
On 02/02/2015 22:09, John Snow wrote:
>
> In this case, only the command header had a utility written for it to
> flip the bits for me. This is part of the FIS, instead, which has no
> explicit flip-on-write mechanism inside of commit.
>
> So, it's correct, but not terribly consistent.
>
> I can write a fis write helper to make this more internally consistent
> about when we handle it for the user and when we don't.
Please do. :)
Paolo
next prev parent reply other threads:[~2015-02-03 8:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 18:41 [Qemu-devel] [PATCH 00/19] qtest/ahci: add dma test John Snow
2015-01-30 18:41 ` [Qemu-devel] [PATCH 01/19] libqos/ahci: Add ahci_port_select helper John Snow
2015-01-30 18:41 ` [Qemu-devel] [PATCH 02/19] libqos/ahci: Add ahci_port_clear helper John Snow
2015-01-30 18:41 ` [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to 'CommandHeader' John Snow
2015-02-02 10:25 ` Paolo Bonzini
2015-01-30 18:41 ` [Qemu-devel] [PATCH 04/19] libqos/ahci: Add command header helpers John Snow
2015-02-02 10:25 ` Paolo Bonzini
2015-02-02 20:33 ` John Snow
2015-02-02 10:27 ` Paolo Bonzini
2015-02-02 20:38 ` John Snow
2015-01-30 18:41 ` [Qemu-devel] [PATCH 05/19] libqos/ahci: Add ahci_port_check_error helper John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 06/19] libqos/ahci: Add ahci_port_check_interrupts helper John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 07/19] libqos/ahci: Add port_check_nonbusy helper John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 08/19] libqos/ahci: Add cmd response sanity check helpers John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 09/19] qtest/ahci: Demagic ahci tests John Snow
2015-02-02 10:33 ` Paolo Bonzini
2015-01-30 18:42 ` [Qemu-devel] [PATCH 10/19] libqos/ahci: Add ide cmd properties John Snow
2015-02-02 10:34 ` Paolo Bonzini
2015-01-30 18:42 ` [Qemu-devel] [PATCH 11/19] libqos/ahci: add ahci command functions John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 12/19] libqos/ahci: add ahci command verify John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters John Snow
2015-02-02 10:35 ` Paolo Bonzini
2015-02-02 21:09 ` John Snow
2015-02-03 8:52 ` Paolo Bonzini [this message]
2015-01-30 18:42 ` [Qemu-devel] [PATCH 14/19] libqos/ahci: Add ahci_guest_io John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 15/19] libqos/ahci: add ahci_io John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 16/19] libqos/ahci: Add ahci_clean_mem John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine John Snow
2015-02-02 10:37 ` Paolo Bonzini
2015-02-02 21:12 ` John Snow
2015-02-03 8:53 ` Paolo Bonzini
2015-01-30 18:42 ` [Qemu-devel] [PATCH 18/19] qtest/ahci: Assert sector size in identify test John Snow
2015-01-30 18:42 ` [Qemu-devel] [PATCH 19/19] qtest/ahci: Adding simple dma read-write test John Snow
2015-02-02 10:38 ` Paolo Bonzini
2015-02-02 10:38 ` [Qemu-devel] [PATCH 00/19] qtest/ahci: add dma test Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D08C4F.5050705@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.