From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG
Date: Tue, 03 Feb 2015 19:37:52 -0500 [thread overview]
Message-ID: <54D169E0.20208@terremark.com> (raw)
In-Reply-To: <54D0B994020000780005C50F@mail.emea.novell.com>
On 02/03/15 06:05, Jan Beulich wrote:
>>>> On 02.02.15 at 16:22, <dslutz@verizon.com> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -2573,6 +2573,7 @@ bool_t hvm_send_assist_req_to_ioreq_server(struct hvm_ioreq_server *s,
>>
>> static bool_t hvm_complete_assist_req(ioreq_t *p)
>> {
>> + ASSERT(p->type != IOREQ_TYPE_PCI_CONFIG);
>> switch ( p->type )
>> {
>> case IOREQ_TYPE_COPY:
>
> The better variant would seem to be case IOREQ_TYPE_PCI_CONFIG
> with ASSERT_UNREACHABLE().
>
Ok, Will change (since there will be a v3)
-Don Slutz
> Jan
>
next prev parent reply other threads:[~2015-02-04 0:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 15:22 [PATCH v2 0/3] Skip unneeded VMENTRY & VMEXIT Don Slutz
2015-02-02 15:22 ` [PATCH v2 1/3] xentrace: Adjust IOPORT & MMIO format Don Slutz
2015-02-05 21:28 ` George Dunlap
2015-02-02 15:22 ` [PATCH v2 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG Don Slutz
2015-02-03 11:05 ` Jan Beulich
2015-02-04 0:37 ` Don Slutz [this message]
2015-02-02 15:22 ` [PATCH v2 3/3] hvm_has_dm: Do a full check for backing DM Don Slutz
2015-02-03 10:37 ` Paul Durrant
2015-02-03 14:58 ` Jan Beulich
2015-02-05 19:02 ` Don Slutz
2015-02-06 7:35 ` Jan Beulich
2015-02-06 17:01 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D169E0.20208@terremark.com \
--to=dslutz@verizon.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.