From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Denis Drozdov <denys.drozdov@globallogic.com>
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
JBeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Fix rtds scheduler for arm
Date: Wed, 04 Feb 2015 16:45:46 +0000 [thread overview]
Message-ID: <54D24CBA.50705@linaro.org> (raw)
In-Reply-To: <1423062826.24924.17.camel@citrix.com>
Hello,
On 04/02/2015 15:13, Ian Campbell wrote:
> On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote:
>> From: denys drozdov <denys.drozdov@globallogic.com>
>>
>> Make Credit2 and RT schedulers to run on arm platform
>> context_saved should be deferred on ARM after IRQs enabled
>
> A better subject+message would be:
>
> xen/arm: Call context_saved() with interrupts enabled during context switch
>
> This is a requirement of the scheduler interface, violating this
> causes for example with the RT scheduler:
> <insert crash log here>
>
>> Signed-off-by: denys drozdov <denys.drozdov@globallogic.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
The commit message suggested by Ian looks more clear to me. With this
change:
Reviewed-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-02-04 16:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 12:30 [PATCH] xen/arm: Fix rtds scheduler for arm Denis Drozdov
2015-01-30 12:38 ` Jan Beulich
2015-01-30 15:40 ` Denis Drozdov
2015-01-30 15:46 ` Julien Grall
2015-01-30 15:56 ` Andrew Cooper
2015-01-30 16:10 ` Julien Grall
2015-01-30 16:19 ` Denys Drozdov
2015-01-30 16:29 ` Julien Grall
2015-01-31 10:50 ` Ian Campbell
2015-02-02 10:49 ` Denys Drozdov
2015-02-02 11:14 ` Ian Campbell
2015-02-02 11:40 ` Jan Beulich
2015-02-02 12:16 ` Ian Campbell
2015-02-02 12:59 ` Julien Grall
2015-02-02 13:06 ` Ian Campbell
2015-02-04 15:04 ` Stefano Stabellini
2015-02-04 15:09 ` Ian Campbell
2015-02-02 13:07 ` Jan Beulich
2015-02-02 18:03 ` Denis Drozdov
2015-02-04 15:13 ` Ian Campbell
2015-02-04 16:19 ` Dario Faggioli
2015-02-04 16:45 ` Julien Grall [this message]
2015-02-04 17:13 ` [PATCH] xen/arm: Call context_saved() with interrupts enabled during context switch Denis Drozdov
2015-02-05 12:48 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D24CBA.50705@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=denys.drozdov@globallogic.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.