All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Denis Drozdov <denys.drozdov@globallogic.com>
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	julien.grall@linaro.org, JBeulich@suse.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Call context_saved() with interrupts enabled during context switch
Date: Thu, 5 Feb 2015 12:48:08 +0000	[thread overview]
Message-ID: <1423140488.24924.108.camel@citrix.com> (raw)
In-Reply-To: <1423069985-26282-1-git-send-email-denys.drozdov@globallogic.com>

On Wed, 2015-02-04 at 19:13 +0200, Denis Drozdov wrote:
> From: denys drozdov <denys.drozdov@globallogic.com>
> 
> This is a requirement of the scheduler interface, violating this
> causes for example with the RT scheduler:
> 
> (XEN) Assertion 'local_irq_is_enabled()' failed at spinlock.c:137
> (XEN) ----[ Xen-4.5.0  arm32  debug=y  Not tainted ]----
> (XEN) CPU:    0
> (XEN) PC:     0022a074 _spin_lock_irq+0x18/0x94
> 
> (XEN) Xen call trace:
> (XEN)    [<0022a074>] _spin_lock_irq+0x18/0x94 (PC)
> (XEN)    [<002256b8>] rt_context_saved+0x3c/0x144 (LR)
> (XEN)    [<002256b8>] rt_context_saved+0x3c/0x144
> (XEN)    [<00228ed8>] context_saved+0x4c/0x80
> (XEN)    [<002524b4>] schedule_tail+0x148/0x2f0
> (XEN)    [<00252668>] continue_new_vcpu+0xc/0x70
> (XEN)    [<00252a18>] context_switch+0x74/0x7c
> 
> 
> Signed-off-by: denys drozdov <denys.drozdov@globallogic.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>

Dario's R-by counts as the scheduled ack I was looking for, so applied
thanks.

      reply	other threads:[~2015-02-05 12:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 12:30 [PATCH] xen/arm: Fix rtds scheduler for arm Denis Drozdov
2015-01-30 12:38 ` Jan Beulich
2015-01-30 15:40   ` Denis Drozdov
2015-01-30 15:46     ` Julien Grall
2015-01-30 15:56       ` Andrew Cooper
2015-01-30 16:10         ` Julien Grall
2015-01-30 16:19           ` Denys Drozdov
2015-01-30 16:29             ` Julien Grall
2015-01-31 10:50             ` Ian Campbell
2015-02-02 10:49               ` Denys Drozdov
2015-02-02 11:14                 ` Ian Campbell
2015-02-02 11:40                   ` Jan Beulich
2015-02-02 12:16                     ` Ian Campbell
2015-02-02 12:59                       ` Julien Grall
2015-02-02 13:06                         ` Ian Campbell
2015-02-04 15:04                         ` Stefano Stabellini
2015-02-04 15:09                           ` Ian Campbell
2015-02-02 13:07                       ` Jan Beulich
2015-02-02 18:03                         ` Denis Drozdov
2015-02-04 15:13                           ` Ian Campbell
2015-02-04 16:19                             ` Dario Faggioli
2015-02-04 16:45                             ` Julien Grall
2015-02-04 17:13                               ` [PATCH] xen/arm: Call context_saved() with interrupts enabled during context switch Denis Drozdov
2015-02-05 12:48                                 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423140488.24924.108.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=denys.drozdov@globallogic.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.