From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fix sparse warnings
Date: Thu, 5 Feb 2015 12:38:55 +0100 [thread overview]
Message-ID: <54D3564F.8000207@sandisk.com> (raw)
In-Reply-To: <1423129268-16220-1-git-send-email-prabhakar.csengg@gmail.com>
On 02/05/15 10:41, Lad Prabhakar wrote:
> this patch fixes following sparse warnings:
> scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared. Should it be static?
> scsi_sysfs.c:376:24: warning: symbol 'scsi_shost_attr_group' was not declared. Should it be static?
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
<linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fix sparse warnings
Date: Thu, 5 Feb 2015 12:38:55 +0100 [thread overview]
Message-ID: <54D3564F.8000207@sandisk.com> (raw)
In-Reply-To: <1423129268-16220-1-git-send-email-prabhakar.csengg@gmail.com>
On 02/05/15 10:41, Lad Prabhakar wrote:
> this patch fixes following sparse warnings:
> scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared. Should it be static?
> scsi_sysfs.c:376:24: warning: symbol 'scsi_shost_attr_group' was not declared. Should it be static?
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2015-02-05 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 9:41 [PATCH] scsi: fix sparse warnings Lad Prabhakar
2015-02-05 11:38 ` Bart Van Assche [this message]
2015-02-05 11:38 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D3564F.8000207@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.