linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

[Wally Yeh]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi, guys:
    Since my board is i.mx6Q sabresd. Only I wanna keep
is CONFIG_SOC_IMX6Q, so I removed all other CONFIG_SOC_* .
    But if I remove CONFIG_SOC_IMX6SL, linux-imx will never build
successfully.

    If this config is really necessary, shouldn't we just make
CONFIG_SOC_IMX6SL always be selected with CONFIG_SOC_IMX6Q?

Wally

[-- Attachment #2: Type: text/html, Size: 471 bytes --]

Re: linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

[Nikolay Dimitrov]

Hi Wally,

On 02/06/2015 11:33 AM, Wally Yeh wrote:
> Hi, guys:
>      Since my board is i.mx6Q sabresd. Only I wanna keep
> is CONFIG_SOC_IMX6Q, so I removed all other CONFIG_SOC_* .
>      But if I remove CONFIG_SOC_IMX6SL, linux-imx will never build
> successfully.
>
>      If this config is really necessary, shouldn't we just make
> CONFIG_SOC_IMX6SL always be selected with CONFIG_SOC_IMX6Q?

The config is needed, as there are hard-coded invocations of
mx6s-specific code in the kernel. If you remove the CONFIG_SOC_IMX6SL,
linkage will fail while looking for stuff like:

imx6sl_set_wait_clk()
init_mmdc_lpddr2_settings()
update_lpddr2_freq()

If you really insist on changing this, you can axe-hack all source
files which contain invocations of cpu_is_imx6sl(). Or, fix it and
submit a patch.

Probably you're right that it could have been implemented better, but
unless we improve it, that's what we have :D.

Kind regards,
Nikolay

Re: linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

[Otavio Salvador]

Hello,

On Fri, Feb 6, 2015 at 8:19 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> On 02/06/2015 11:33 AM, Wally Yeh wrote:
>> Hi, guys:
>>      Since my board is i.mx6Q sabresd. Only I wanna keep
>> is CONFIG_SOC_IMX6Q, so I removed all other CONFIG_SOC_* .
>>      But if I remove CONFIG_SOC_IMX6SL, linux-imx will never build
>> successfully.
>>
>>      If this config is really necessary, shouldn't we just make
>> CONFIG_SOC_IMX6SL always be selected with CONFIG_SOC_IMX6Q?
>
>
> The config is needed, as there are hard-coded invocations of
> mx6s-specific code in the kernel. If you remove the CONFIG_SOC_IMX6SL,
> linkage will fail while looking for stuff like:
>
> imx6sl_set_wait_clk()
> init_mmdc_lpddr2_settings()
> update_lpddr2_freq()
>
> If you really insist on changing this, you can axe-hack all source
> files which contain invocations of cpu_is_imx6sl(). Or, fix it and
> submit a patch.
>
> Probably you're right that it could have been implemented better, but
> unless we improve it, that's what we have :D.

Please prepare a patch for it, so we get it fixed :-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

[Wally Yeh]

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

Hi, Nikolay:
    Thanks for answer. :D

    I'm not a imx expert, but I'll try. Now there's two way I can do:
1. just auto select CONFIG_SOC_IMX6SL if CONFIG_SOC_IMX6Q selected. not
sure is there any CONFIG_SOC_* also need select CONFIG_SOC_IMX6SL.
2. adding #ifdef  CONFIG_SOC_IMX6SL into the function which hard-coded
invocations of mx6s-specific code .

   I don't know which one is better. any suggestion is welcome.

Wally




2015-02-06 19:00 GMT+08:00 Otavio Salvador <otavio@ossystems.com.br>:

> Hello,
>
> On Fri, Feb 6, 2015 at 8:19 AM, Nikolay Dimitrov <picmaster@mail.bg>
> wrote:
> > On 02/06/2015 11:33 AM, Wally Yeh wrote:
> >> Hi, guys:
> >>      Since my board is i.mx6Q sabresd. Only I wanna keep
> >> is CONFIG_SOC_IMX6Q, so I removed all other CONFIG_SOC_* .
> >>      But if I remove CONFIG_SOC_IMX6SL, linux-imx will never build
> >> successfully.
> >>
> >>      If this config is really necessary, shouldn't we just make
> >> CONFIG_SOC_IMX6SL always be selected with CONFIG_SOC_IMX6Q?
> >
> >
> > The config is needed, as there are hard-coded invocations of
> > mx6s-specific code in the kernel. If you remove the CONFIG_SOC_IMX6SL,
> > linkage will fail while looking for stuff like:
> >
> > imx6sl_set_wait_clk()
> > init_mmdc_lpddr2_settings()
> > update_lpddr2_freq()
> >
> > If you really insist on changing this, you can axe-hack all source
> > files which contain invocations of cpu_is_imx6sl(). Or, fix it and
> > submit a patch.
> >
> > Probably you're right that it could have been implemented better, but
> > unless we improve it, that's what we have :D.
>
> Please prepare a patch for it, so we get it fixed :-)
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 3501 bytes --]

Re: linux-imx 3.10.17 can't build without CONFIG_SOC_IMX6SL selected.

[Otavio Salvador]

On Fri, Feb 6, 2015 at 9:12 AM, Wally Yeh <wally.yeh@atrustcorp.com> wrote:
> 1. just auto select CONFIG_SOC_IMX6SL if CONFIG_SOC_IMX6Q selected. not sure
> is there any CONFIG_SOC_* also need select CONFIG_SOC_IMX6SL.
> 2. adding #ifdef  CONFIG_SOC_IMX6SL into the function which hard-coded
> invocations of mx6s-specific code .
>
>    I don't know which one is better. any suggestion is welcome.

I prefer the second option. It allow for removing more code :)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750