From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Kukjin Kim <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrzej Hajda <a.hajda@samsung.com>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs
Date: Fri, 06 Feb 2015 22:09:36 +0300 [thread overview]
Message-ID: <54D51170.10903@cogentembedded.com> (raw)
In-Reply-To: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk>
Hello.
On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote:
> All the device nodes for the Exynos5420 power-domains have a quite
> generic "power-domain" name.
And this is in conformance to the ePAPR standard.
> So in case of an error, the Exynos PD
> driver shows the following (not very useful) message:
> "Power domain power-domain disable failed"
Why not fix the message instead to use the full device name?
> Use descriptive names to know on which PD enable or disable failed.
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs
Date: Fri, 06 Feb 2015 22:09:36 +0300 [thread overview]
Message-ID: <54D51170.10903@cogentembedded.com> (raw)
In-Reply-To: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk>
Hello.
On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote:
> All the device nodes for the Exynos5420 power-domains have a quite
> generic "power-domain" name.
And this is in conformance to the ePAPR standard.
> So in case of an error, the Exynos PD
> driver shows the following (not very useful) message:
> "Power domain power-domain disable failed"
Why not fix the message instead to use the full device name?
> Use descriptive names to know on which PD enable or disable failed.
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
WBR, Sergei
next prev parent reply other threads:[~2015-02-06 19:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 17:37 [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs Javier Martinez Canillas
2015-02-06 17:37 ` Javier Martinez Canillas
2015-02-06 19:09 ` Sergei Shtylyov [this message]
2015-02-06 19:09 ` Sergei Shtylyov
2015-02-06 20:50 ` Javier Martinez Canillas
2015-02-06 20:50 ` Javier Martinez Canillas
2015-02-10 11:46 ` Krzysztof Kozlowski
2015-02-10 11:46 ` Krzysztof Kozlowski
2015-02-10 11:55 ` Sergei Shtylyov
2015-02-10 11:55 ` Sergei Shtylyov
2015-02-10 12:17 ` Krzysztof Kozlowski
2015-02-10 12:17 ` Krzysztof Kozlowski
2015-02-10 12:21 ` Sergei Shtylyov
2015-02-10 12:21 ` Sergei Shtylyov
2015-02-10 12:30 ` Krzysztof Kozlowski
2015-02-10 12:30 ` Krzysztof Kozlowski
2015-02-10 12:46 ` Javier Martinez Canillas
2015-02-10 12:46 ` Javier Martinez Canillas
2015-02-10 13:00 ` Sylwester Nawrocki
2015-02-10 13:00 ` Sylwester Nawrocki
2015-02-10 13:14 ` Krzysztof Kozlowski
2015-02-10 13:14 ` Krzysztof Kozlowski
2015-02-10 14:08 ` Sylwester Nawrocki
2015-02-10 14:08 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D51170.10903@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=a.hajda@samsung.com \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.