From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [PATCH] memsave: Improve and disambiguate error message
Date: Sun, 08 Feb 2015 22:46:05 +0100 [thread overview]
Message-ID: <54D7D91D.2040505@redhat.com> (raw)
In-Reply-To: <20150208121438.GA6290@pd.tnic>
On 08/02/2015 13:14, Borislav Petkov wrote:
> On Sun, Feb 08, 2015 at 11:09:24AM +0100, Paolo Bonzini wrote:
>> Cc: qemu-trivial@nongnu.org
>
> Thanks.
>
> But, there's more b0rked with this error message so you might wanna take
> the patch below instead.
>
> Btw, what are the vim settings when doing patches for qemu, this must be
> documented somewhere as coding style differs significantly from that of
> the kernel?
I use ":set shiftwidth=4 expandtab" and c-indent mode.
Quick googling for "vim four spaces" suggests the following alternatives:
* ":set tabstop=8 expandtab shiftwidth=4 softtabstop=4"
* "set tabstop=8 softtabstop=0 expandtab shiftwidth=4 smarttab".
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] memsave: Improve and disambiguate error message
Date: Sun, 08 Feb 2015 22:46:05 +0100 [thread overview]
Message-ID: <54D7D91D.2040505@redhat.com> (raw)
In-Reply-To: <20150208121438.GA6290@pd.tnic>
On 08/02/2015 13:14, Borislav Petkov wrote:
> On Sun, Feb 08, 2015 at 11:09:24AM +0100, Paolo Bonzini wrote:
>> Cc: qemu-trivial@nongnu.org
>
> Thanks.
>
> But, there's more b0rked with this error message so you might wanna take
> the patch below instead.
>
> Btw, what are the vim settings when doing patches for qemu, this must be
> documented somewhere as coding style differs significantly from that of
> the kernel?
I use ":set shiftwidth=4 expandtab" and c-indent mode.
Quick googling for "vim four spaces" suggests the following alternatives:
* ":set tabstop=8 expandtab shiftwidth=4 softtabstop=4"
* "set tabstop=8 softtabstop=0 expandtab shiftwidth=4 smarttab".
Paolo
next prev parent reply other threads:[~2015-02-08 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 20:29 [Qemu-devel] [PATCH] memsave: Add a space after address in error message Borislav Petkov
2015-02-08 10:09 ` [Qemu-trivial] " Paolo Bonzini
2015-02-08 10:09 ` [Qemu-devel] " Paolo Bonzini
2015-02-08 12:14 ` [Qemu-trivial] [PATCH] memsave: Improve and disambiguate " Borislav Petkov
2015-02-08 12:14 ` [Qemu-devel] " Borislav Petkov
2015-02-08 21:46 ` Paolo Bonzini [this message]
2015-02-08 21:46 ` Paolo Bonzini
2015-02-10 9:22 ` [Qemu-trivial] " Borislav Petkov
2015-02-10 9:22 ` [Qemu-devel] " Borislav Petkov
2015-02-10 19:06 ` [Qemu-trivial] " Michael Tokarev
2015-02-10 19:06 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D7D91D.2040505@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=bp@alien8.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.