From: Chanwoo Choi <cw00.choi@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] PM / devfreq: event: testing the wrong variable
Date: Tue, 10 Feb 2015 10:59:40 +0000 [thread overview]
Message-ID: <54D9E49C.80105@samsung.com> (raw)
In-Reply-To: <20150210103547.GA18481@mwanda>
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] PM / devfreq: event: testing the wrong variable
Date: Tue, 10 Feb 2015 19:59:40 +0900 [thread overview]
Message-ID: <54D9E49C.80105@samsung.com> (raw)
In-Reply-To: <20150210103547.GA18481@mwanda>
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] PM / devfreq: event: testing the wrong variable
Date: Tue, 10 Feb 2015 19:59:40 +0900 [thread overview]
Message-ID: <54D9E49C.80105@samsung.com> (raw)
In-Reply-To: <20150210103547.GA18481@mwanda>
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-02-10 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 10:35 [patch] PM / devfreq: event: testing the wrong variable Dan Carpenter
2015-02-10 10:35 ` Dan Carpenter
2015-02-10 10:35 ` Dan Carpenter
2015-02-10 10:59 ` Chanwoo Choi [this message]
2015-02-10 10:59 ` Chanwoo Choi
2015-02-10 10:59 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2015-02-12 9:00 MyungJoo Ham
2015-02-12 9:00 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9E49C.80105@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.