From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
port-xen@netbsd.org, stefano.stabellini@eu.citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, Jan Beulich <JBeulich@suse.com>,
keir@xen.org, ufimtseva@gmail.com
Subject: Re: [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup)
Date: Tue, 10 Feb 2015 11:08:30 +0000 [thread overview]
Message-ID: <54D9E6AE.7030609@citrix.com> (raw)
In-Reply-To: <54D9D4FB020000780005E78B@mail.emea.novell.com>
On 10/02/15 08:52, Jan Beulich wrote:
>>>> On 09.02.15 at 21:04, <boris.ostrovsky@oracle.com> wrote:
>> * Make changes to xen_sysctl_numainfo, similar to those made to
>> xen_sysctl_topologyinfo. (Q: I kept both sets of changes in the same
>> patch #3 to avoid bumping interface version twice. Perhaps it's better
>> to split it into two?)
> There's no need to bump it more than once between releases.
> Hence yes - splitting would be better.
I will wait until patch 3 is split to do an in-depth review, but one
thing you need to fix is that the INVALID_$FOO identifiers need a XEN_
prefix to put them in the same namespace as the other identifiers.
~Andrew
next prev parent reply other threads:[~2015-02-10 11:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 20:04 [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-02-09 20:04 ` [PATCH v3 1/7] x86/numa: Make use of NUMA_NO_NODE consistent Boris Ostrovsky
2015-02-10 10:41 ` Andrew Cooper
2015-02-10 11:39 ` Jan Beulich
[not found] ` <54D9FBE7020000780005E91E@mail.emea.novell.com>
2015-02-10 14:55 ` Boris Ostrovsky
[not found] ` <54D9E076.1080604@citrix.com>
2015-02-16 13:57 ` Dario Faggioli
2015-02-09 20:04 ` [PATCH v3 2/7] pci: Do not ignore device's PXM information Boris Ostrovsky
2015-02-09 20:04 ` [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient Boris Ostrovsky
2015-02-13 12:26 ` Wei Liu
[not found] ` <20150213122609.GU13644@zion.uk.xensource.com>
2015-02-13 14:21 ` Boris Ostrovsky
2015-02-16 14:08 ` Dario Faggioli
2015-02-16 15:55 ` Boris Ostrovsky
2015-02-23 16:40 ` Ian Campbell
[not found] ` <1424709653.27930.212.camel@citrix.com>
2015-02-23 16:48 ` Boris Ostrovsky
[not found] ` <54EB59F0.2070405@oracle.com>
2015-02-23 16:59 ` Jan Beulich
[not found] ` <54EB6A770200007800062BDD@mail.emea.novell.com>
2015-02-23 17:15 ` Ian Campbell
2015-02-09 20:04 ` [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
2015-02-10 10:26 ` Robert Elz
2015-02-10 11:13 ` Andrew Cooper
2015-02-10 14:45 ` Boris Ostrovsky
[not found] ` <54DA19A4.8070603@oracle.com>
2015-02-10 14:54 ` Andrew Cooper
[not found] ` <54DA1BC1.2030205@citrix.com>
2015-02-10 15:06 ` Boris Ostrovsky
[not found] ` <54DA1E6D.2010401@oracle.com>
2015-02-10 16:30 ` Jan Beulich
[not found] ` <54DA322B02000078000C8167@mail.emea.novell.com>
2015-02-10 16:33 ` Andrew Cooper
2015-02-09 20:04 ` [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-02-10 11:23 ` Andrew Cooper
2015-02-10 14:48 ` Boris Ostrovsky
2015-02-16 14:22 ` Dario Faggioli
2015-02-23 16:44 ` Ian Campbell
[not found] ` <1424709863.27930.214.camel@citrix.com>
2015-02-23 16:52 ` Boris Ostrovsky
[not found] ` <54EB5AC9.7070409@oracle.com>
2015-02-23 17:14 ` Ian Campbell
2015-02-23 17:59 ` Boris Ostrovsky
2015-02-09 20:04 ` [PATCH v3 6/7] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-02-09 20:04 ` [PATCH v3 7/7] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-02-13 12:43 ` Wei Liu
[not found] ` <20150213124345.GV13644@zion.uk.xensource.com>
2015-02-13 14:22 ` Boris Ostrovsky
2015-02-16 13:45 ` Dario Faggioli
2015-02-16 15:54 ` Boris Ostrovsky
[not found] ` <54E212A3.7000802@oracle.com>
2015-02-16 16:06 ` Dario Faggioli
2015-02-16 16:47 ` Wei Liu
2015-02-23 16:52 ` Ian Campbell
2015-02-10 8:52 ` [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup) Jan Beulich
2015-02-10 11:08 ` Andrew Cooper [this message]
[not found] ` <1423512275-6531-3-git-send-email-boris.ostrovsky@oracle.com>
2015-02-10 10:45 ` [PATCH v3 2/7] pci: Do not ignore device's PXM information Andrew Cooper
2015-02-10 11:43 ` Jan Beulich
[not found] ` <1423512275-6531-7-git-send-email-boris.ostrovsky@oracle.com>
2015-02-10 11:45 ` [PATCH v3 6/7] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc Andrew Cooper
[not found] ` <54D9EF57.7050308@citrix.com>
2015-02-10 14:59 ` Boris Ostrovsky
2015-02-23 16:45 ` Ian Campbell
[not found] ` <2508.1423564006@perseus.noi.kre.to>
2015-02-10 14:37 ` [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9E6AE.7030609@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=port-xen@netbsd.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.