All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [resend PATCH v3 2/4] Documentation: dt-bindings: add dt binding info for hi6220
Date: Tue, 10 Feb 2015 14:37:01 +0300	[thread overview]
Message-ID: <54D9ED5D.2000001@cogentembedded.com> (raw)
In-Reply-To: <1423559404-13058-3-git-send-email-zhangfei.gao@linaro.org>

Hello.

On 2/10/2015 12:10 PM, Zhangfei Gao wrote:

> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/usb/hi6220-usb.txt         | 49 ++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/hi6220-usb.txt

> diff --git a/Documentation/devicetree/bindings/usb/hi6220-usb.txt b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> new file mode 100644
> index 0000000..b8278de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> @@ -0,0 +1,49 @@
> +Hisilicon hi6220 SoC USB controller
> +-----------------------------
[...]
> +PHY:
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"
> +- vcc-supply: phandle to the regulator that provides power to the PHY.
> +- clocks: phandle and clock specifier of the PHY clock.
> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
> +- hisilicon,gpio-vbus: gpio of detecting vbus.
> +- hisilicon,gpio-id: gpio of detecting id.

    Actually, GPIO bindings say that GPIO properties should be named 
"[<name>-]gpios".

> +
> +Example:
> +
> +	peripheral_ctrl: syscon at f7030000 {
> +	        compatible = "syscon";
> +	        reg = <0x0 0xf7030000 0x0 0x1000>;
> +	};
> +
> +	usb2_phy: usbphy {

    Please name it "usb-phy" as it better resembles "ethernet-phy" 
standardized by ePAPR.

[...]

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Zhangfei Gao
	<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	balbi-l0cyMroinI0@public.gmane.org,
	john.youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
	Mian Yousaf Kaukab
	<yousaf.kaukab-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"dan . zhao" <dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Wangbinghui <wangbinghui-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [resend PATCH v3 2/4] Documentation: dt-bindings: add dt binding info for hi6220
Date: Tue, 10 Feb 2015 14:37:01 +0300	[thread overview]
Message-ID: <54D9ED5D.2000001@cogentembedded.com> (raw)
In-Reply-To: <1423559404-13058-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Hello.

On 2/10/2015 12:10 PM, Zhangfei Gao wrote:

> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>   .../devicetree/bindings/usb/hi6220-usb.txt         | 49 ++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/hi6220-usb.txt

> diff --git a/Documentation/devicetree/bindings/usb/hi6220-usb.txt b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> new file mode 100644
> index 0000000..b8278de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
> @@ -0,0 +1,49 @@
> +Hisilicon hi6220 SoC USB controller
> +-----------------------------
[...]
> +PHY:
> +-----
> +
> +Required properties:
> +- compatible: "hisilicon,hi6220-usb-phy"
> +- vcc-supply: phandle to the regulator that provides power to the PHY.
> +- clocks: phandle and clock specifier of the PHY clock.
> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
> +- hisilicon,gpio-vbus: gpio of detecting vbus.
> +- hisilicon,gpio-id: gpio of detecting id.

    Actually, GPIO bindings say that GPIO properties should be named 
"[<name>-]gpios".

> +
> +Example:
> +
> +	peripheral_ctrl: syscon@f7030000 {
> +	        compatible = "syscon";
> +	        reg = <0x0 0xf7030000 0x0 0x1000>;
> +	};
> +
> +	usb2_phy: usbphy {

    Please name it "usb-phy" as it better resembles "ethernet-phy" 
standardized by ePAPR.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-02-10 11:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  9:10 [resend PATCH v3 0/4] add usb support for hi6220 Zhangfei Gao
2015-02-10  9:10 ` Zhangfei Gao
2015-02-10  9:10 ` [resend PATCH v3 1/4] Documentation: dt-bindings: add dt binding info for hi6220 dwc2 Zhangfei Gao
2015-02-10  9:10   ` Zhangfei Gao
2015-02-10  9:10 ` [resend PATCH v3 2/4] Documentation: dt-bindings: add dt binding info for hi6220 Zhangfei Gao
2015-02-10  9:10   ` Zhangfei Gao
2015-02-10 11:37   ` Sergei Shtylyov [this message]
2015-02-10 11:37     ` Sergei Shtylyov
2015-02-10  9:10 ` [resend PATCH v3 3/4] usb: dwc2: platform: add hi6220 support Zhangfei Gao
2015-02-10  9:10   ` Zhangfei Gao
2015-02-10  9:10 ` [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb Zhangfei Gao
2015-02-10  9:10   ` Zhangfei Gao
2015-02-10 14:48   ` Felipe Balbi
2015-02-10 14:48     ` Felipe Balbi
2015-02-10 14:53     ` zhangfei
2015-02-10 14:53       ` zhangfei
2015-02-23 15:29       ` Felipe Balbi
2015-02-23 15:29         ` Felipe Balbi
2015-02-11  1:30     ` Peter Chen
2015-02-11  1:30       ` Peter Chen
2015-02-11  9:10       ` Baruch Siach
2015-02-11  9:10         ` Baruch Siach
2015-02-23 15:30         ` Felipe Balbi
2015-02-23 15:30           ` Felipe Balbi
2015-02-23 15:29       ` Felipe Balbi
2015-02-23 15:29         ` Felipe Balbi
2015-02-11 15:17     ` zhangfei
2015-02-11 15:17       ` zhangfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D9ED5D.2000001@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.