All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Jarkko Sakkinen"
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Peter Hüwe" <PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
Cc: Ashley Lai <ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org>,
	Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org>,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
	christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] tpm, tpm_tis: fix TPM 2.0 probing
Date: Tue, 10 Feb 2015 07:16:32 -0500	[thread overview]
Message-ID: <54D9F6A0.9010905@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150209083947.GC29987-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On 02/09/2015 03:39 AM, Jarkko Sakkinen wrote:
> On Mon, Feb 09, 2015 at 12:08:46AM +0100, Peter Hüwe wrote:
>> Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
>>> If during transmission system error was returned, the logic was to
>>> incorrectly deduce that chip is a TPM 1.x chip. This patch fixes this
>>> issue. Also, this patch changes probing so that message tag is used as the
>>> measure for TPM 2.x, which should be much more stable.
>> Is it aware that some TPMs may respond with 0x00C1 as TAG for TPM1.2 commands?
> I guess none of the TPM 1.2 command answer with the tag 0x8002?


FYI: pdf page 26 , section 6.1 explains the predictable return value for 
a TPM1.2 command seen by a TPM2

http://www.trustedcomputinggroup.org/files/static_page_files/8C68ADA8-1A4B-B294-D0FC06D3773F7DAA/TPM%20Rev%202.0%20Part%203%20-%20Commands%2001.16-code.pdf

Following this:

Sending a TPM1.2 command to a TPM2 should return a TPM1.2 header (tag = 
0xc4) and error code (TPM_BADTAG = 0x1e)

Sending a TPM 2 command to a TPM 2 will give a TPM 2 tag in the header.
Sending a TPM 2 command to a TPM 1.2 will give a TPM 1.2 tag in the 
header and an error code.


    Stefan

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: "Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
	"Peter Hüwe" <PeterHuewe@gmx.de>
Cc: Ashley Lai <ashley@ashleylai.com>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	josh@joshtriplett.org, christophe.ricard@gmail.com,
	jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
	trousers-tech@lists.sourceforge.net
Subject: Re: [PATCH] tpm, tpm_tis: fix TPM 2.0 probing
Date: Tue, 10 Feb 2015 07:16:32 -0500	[thread overview]
Message-ID: <54D9F6A0.9010905@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150209083947.GC29987@intel.com>

On 02/09/2015 03:39 AM, Jarkko Sakkinen wrote:
> On Mon, Feb 09, 2015 at 12:08:46AM +0100, Peter Hüwe wrote:
>> Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
>>> If during transmission system error was returned, the logic was to
>>> incorrectly deduce that chip is a TPM 1.x chip. This patch fixes this
>>> issue. Also, this patch changes probing so that message tag is used as the
>>> measure for TPM 2.x, which should be much more stable.
>> Is it aware that some TPMs may respond with 0x00C1 as TAG for TPM1.2 commands?
> I guess none of the TPM 1.2 command answer with the tag 0x8002?


FYI: pdf page 26 , section 6.1 explains the predictable return value for 
a TPM1.2 command seen by a TPM2

http://www.trustedcomputinggroup.org/files/static_page_files/8C68ADA8-1A4B-B294-D0FC06D3773F7DAA/TPM%20Rev%202.0%20Part%203%20-%20Commands%2001.16-code.pdf

Following this:

Sending a TPM1.2 command to a TPM2 should return a TPM1.2 header (tag = 
0xc4) and error code (TPM_BADTAG = 0x1e)

Sending a TPM 2 command to a TPM 2 will give a TPM 2 tag in the header.
Sending a TPM 2 command to a TPM 1.2 will give a TPM 1.2 tag in the 
header and an error code.


    Stefan


  parent reply	other threads:[~2015-02-10 12:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 14:21 [PATCH] tpm, tpm_tis: fix TPM 2.0 probing Jarkko Sakkinen
2015-02-04 14:21 ` Jarkko Sakkinen
     [not found] ` <1423059669-31734-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-02-08 23:08   ` Peter Hüwe
2015-02-08 23:08     ` Peter Hüwe
2015-02-09  8:39     ` Jarkko Sakkinen
2015-02-09  9:20       ` [tpmdd-devel] " peterhuewe
     [not found]       ` <20150209083947.GC29987-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-10 12:16         ` Stefan Berger [this message]
2015-02-10 12:16           ` Stefan Berger
     [not found]           ` <54D9F6A0.9010905-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2015-02-10 12:50             ` Jarkko Sakkinen
2015-02-10 12:50               ` Jarkko Sakkinen
     [not found]               ` <20150210125037.GB4313-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-11 18:47                 ` Stefan Berger
2015-02-11 18:47                   ` Stefan Berger
     [not found]                   ` <54DBA3A5.7090306-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2015-02-12  5:25                     ` Jarkko Sakkinen
2015-02-12  5:25                       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D9F6A0.9010905@linux.vnet.ibm.com \
    --to=stefanb-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=PeterHuewe-Mmb7MZpHnFY@public.gmane.org \
    --cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
    --cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org \
    --cc=trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.