All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Bas Peters <baspeters93@gmail.com>, Chris Mason <clm@fb.com>,
	David Sterba <dsterba@suse.cz>, Josef Bacik <jbacik@fb.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()
Date: Wed, 11 Feb 2015 11:30:54 +0000	[thread overview]
Message-ID: <54DB3D6E.5000304@users.sourceforge.net> (raw)
In-Reply-To: <1423646233-16637-1-git-send-email-baspeters93@gmail.com>

> kfree checks whether the pointer it is passed is NULL. The two foregoing
> checks are therefore unnecessary.
> 
> This issue was detected using Coccinelle.

Would you like to integrate my update suggestion "btrfs: Deletion of
unnecessary checks before six function calls"?
https://lkml.org/lkml/2014/10/31/606
http://article.gmane.org/gmane.linux.kernel/1818924
https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html

Regards,
Markus


WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Bas Peters <baspeters93@gmail.com>, Chris Mason <clm@fb.com>,
	David Sterba <dsterba@suse.cz>, Josef Bacik <jbacik@fb.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()
Date: Wed, 11 Feb 2015 12:30:54 +0100	[thread overview]
Message-ID: <54DB3D6E.5000304@users.sourceforge.net> (raw)
In-Reply-To: <1423646233-16637-1-git-send-email-baspeters93@gmail.com>

> kfree checks whether the pointer it is passed is NULL. The two foregoing
> checks are therefore unnecessary.
> 
> This issue was detected using Coccinelle.

Would you like to integrate my update suggestion "btrfs: Deletion of
unnecessary checks before six function calls"?
https://lkml.org/lkml/2014/10/31/606
http://article.gmane.org/gmane.linux.kernel/1818924
https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html

Regards,
Markus


  parent reply	other threads:[~2015-02-11 11:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  9:17 [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree() Bas Peters
2015-02-11  9:17 ` Bas Peters
2015-02-11  9:34 ` Julia Lawall
2015-02-11  9:34   ` Julia Lawall
2015-02-11 11:30 ` SF Markus Elfring [this message]
2015-02-11 11:30   ` SF Markus Elfring
2015-02-11 11:49   ` Bas Peters
2015-02-11 11:49     ` Bas Peters
2015-02-11 12:18     ` SF Markus Elfring
2015-02-11 12:18       ` SF Markus Elfring
2015-02-11 12:19       ` Bas Peters
2015-02-11 12:19         ` Bas Peters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DB3D6E.5000304@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=baspeters93@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.cz \
    --cc=jbacik@fb.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.