SHEC updates to the erasure code non regression corpus

SHEC updates to the erasure code non regression corpus

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

Hi,

I've updated the erasure code corpus that verifies the encoding of erasure coded chunks do not change over time with a version that includes the SHEC erasure code plugin.

https://github.com/ceph/ceph-erasure-code-corpus/commit/498b0102955b747813182734e13e75195f2a02a9

From now on it will run each time someone does "make check", but only if the sources are after

$ git rev-parse v0.92-988-g7df0556
7df0556210be3afdc02e2ca41b3a3b60569b753a

I would be grateful if you could verify that it works as intended. The process for updating the corpus has been documented at https://github.com/ceph/ceph-erasure-code-corpus#ceph-erasure-code-corpus : it was difficult to guess how it works ;-)

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

RE: SHEC updates to the erasure code non regression corpus

[Miyamae, Takeshi]

Hi Loic,

> I would be grateful if you could verify that it works as intended.

We have tried create and check actions once for each. It seems it works well.
Is that enough for your job?

Best regards,
Takeshi Miyamae

-----Original Message-----
From: ceph-devel-owner@vger.kernel.org [mailto:ceph-devel-owner@vger.kernel.org] On Behalf Of Loic Dachary
Sent: Wednesday, February 11, 2015 9:28 PM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development
Subject: SHEC updates to the erasure code non regression corpus

Hi,

I've updated the erasure code corpus that verifies the encoding of erasure coded chunks do not change over time with a version that includes the SHEC erasure code plugin.

https://github.com/ceph/ceph-erasure-code-corpus/commit/498b0102955b747813182734e13e75195f2a02a9

From now on it will run each time someone does "make check", but only if the sources are after

$ git rev-parse v0.92-988-g7df0556
7df0556210be3afdc02e2ca41b3a3b60569b753a

I would be grateful if you could verify that it works as intended. The process for updating the corpus has been documented at https://github.com/ceph/ceph-erasure-code-corpus#ceph-erasure-code-corpus : it was difficult to guess how it works ;-)

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre

Re: SHEC updates to the erasure code non regression corpus

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

Hi,

It turned out to be a problem with tests and uninitialized memory which I was able to fix with

https://github.com/ceph/ceph/commit/1a9d717d1661e1e9c9eda3749b7d9c8882a995d2

What surprises me is that we did not catch that before. If I remember correctly we ran valgrind and it was clean. Would you have time to review the tests once more to see if you can maybe catch another minor problem ?

Cheers

On 12/02/2015 09:43, Miyamae, Takeshi wrote:
> Hi Loic,
> 
>> I would be grateful if you could verify that it works as intended.
> 
> We have tried create and check actions once for each. It seems it works well.
> Is that enough for your job?
> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: ceph-devel-owner@vger.kernel.org [mailto:ceph-devel-owner@vger.kernel.org] On Behalf Of Loic Dachary
> Sent: Wednesday, February 11, 2015 9:28 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development
> Subject: SHEC updates to the erasure code non regression corpus
> 
> Hi,
> 
> I've updated the erasure code corpus that verifies the encoding of erasure coded chunks do not change over time with a version that includes the SHEC erasure code plugin.
> 
> https://github.com/ceph/ceph-erasure-code-corpus/commit/498b0102955b747813182734e13e75195f2a02a9
> 
> From now on it will run each time someone does "make check", but only if the sources are after
> 
> $ git rev-parse v0.92-988-g7df0556
> 7df0556210be3afdc02e2ca41b3a3b60569b753a
> 
> I would be grateful if you could verify that it works as intended. The process for updating the corpus has been documented at https://github.com/ceph/ceph-erasure-code-corpus#ceph-erasure-code-corpus : it was difficult to guess how it works ;-)
> 
> Cheers
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: SHEC updates to the erasure code non regression corpus

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]

Please ignore this mail, I confused the two threads and you already answered with https://github.com/ceph/ceph/pull/3716. Great :-)

On 12/02/2015 10:13, Loic Dachary wrote:
> Hi,
> 
> It turned out to be a problem with tests and uninitialized memory which I was able to fix with
> 
> https://github.com/ceph/ceph/commit/1a9d717d1661e1e9c9eda3749b7d9c8882a995d2
> 
> What surprises me is that we did not catch that before. If I remember correctly we ran valgrind and it was clean. Would you have time to review the tests once more to see if you can maybe catch another minor problem ?
> 
> Cheers
> 
> On 12/02/2015 09:43, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>>> I would be grateful if you could verify that it works as intended.
>>
>> We have tried create and check actions once for each. It seems it works well.
>> Is that enough for your job?
>>
>> Best regards,
>> Takeshi Miyamae
>>
>> -----Original Message-----
>> From: ceph-devel-owner@vger.kernel.org [mailto:ceph-devel-owner@vger.kernel.org] On Behalf Of Loic Dachary
>> Sent: Wednesday, February 11, 2015 9:28 PM
>> To: Miyamae, Takeshi/宮前 剛
>> Cc: Ceph Development
>> Subject: SHEC updates to the erasure code non regression corpus
>>
>> Hi,
>>
>> I've updated the erasure code corpus that verifies the encoding of erasure coded chunks do not change over time with a version that includes the SHEC erasure code plugin.
>>
>> https://github.com/ceph/ceph-erasure-code-corpus/commit/498b0102955b747813182734e13e75195f2a02a9
>>
>> From now on it will run each time someone does "make check", but only if the sources are after
>>
>> $ git rev-parse v0.92-988-g7df0556
>> 7df0556210be3afdc02e2ca41b3a3b60569b753a
>>
>> I would be grateful if you could verify that it works as intended. The process for updating the corpus has been documented at https://github.com/ceph/ceph-erasure-code-corpus#ceph-erasure-code-corpus : it was difficult to guess how it works ;-)
>>
>> Cheers
>>
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: SHEC updates to the erasure code non regression corpus

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]



On 12/02/2015 09:43, Miyamae, Takeshi wrote:
> Hi Loic,
> 
>> I would be grateful if you could verify that it works as intended.
> 
> We have tried create and check actions once for each. It seems it works well.
> Is that enough for your job?

Yes, thank you :-)

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: ceph-devel-owner@vger.kernel.org [mailto:ceph-devel-owner@vger.kernel.org] On Behalf Of Loic Dachary
> Sent: Wednesday, February 11, 2015 9:28 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development
> Subject: SHEC updates to the erasure code non regression corpus
> 
> Hi,
> 
> I've updated the erasure code corpus that verifies the encoding of erasure coded chunks do not change over time with a version that includes the SHEC erasure code plugin.
> 
> https://github.com/ceph/ceph-erasure-code-corpus/commit/498b0102955b747813182734e13e75195f2a02a9
> 
> From now on it will run each time someone does "make check", but only if the sources are after
> 
> $ git rev-parse v0.92-988-g7df0556
> 7df0556210be3afdc02e2ca41b3a3b60569b753a
> 
> I would be grateful if you could verify that it works as intended. The process for updating the corpus has been documented at https://github.com/ceph/ceph-erasure-code-corpus#ceph-erasure-code-corpus : it was difficult to guess how it works ;-)
> 
> Cheers
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]