From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>, <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] spice: fix memory leak
Date: Thu, 12 Feb 2015 10:14:51 +0800 [thread overview]
Message-ID: <54DC0C9B.40505@huawei.com> (raw)
In-Reply-To: <1423673410-15100-1-git-send-email-kraxel@redhat.com>
On 2015/2/12 0:50, Gerd Hoffmann wrote:
> Found by coverity.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index c3cc060..2c37953 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict,
> if (strcmp(protocol, "spice") == 0) {
> if (!qemu_using_spice(&err)) {
> qerror_report_err(err);
> + error_free(err);
> return -1;
> }
>
>
Hi, Gerd
the err variable should be initialized to NULL.
This leak had been fixed by:
http://patchwork.ozlabs.org/patch/438696/
and v2:
[PATCH v2] monitor: Fix missing err = NULL in client_migrate_info()
Regards,
-Gonglei
WARNING: multiple messages have this Message-ID (diff)
From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] spice: fix memory leak
Date: Thu, 12 Feb 2015 10:14:51 +0800 [thread overview]
Message-ID: <54DC0C9B.40505@huawei.com> (raw)
In-Reply-To: <1423673410-15100-1-git-send-email-kraxel@redhat.com>
On 2015/2/12 0:50, Gerd Hoffmann wrote:
> Found by coverity.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index c3cc060..2c37953 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict,
> if (strcmp(protocol, "spice") == 0) {
> if (!qemu_using_spice(&err)) {
> qerror_report_err(err);
> + error_free(err);
> return -1;
> }
>
>
Hi, Gerd
the err variable should be initialized to NULL.
This leak had been fixed by:
http://patchwork.ozlabs.org/patch/438696/
and v2:
[PATCH v2] monitor: Fix missing err = NULL in client_migrate_info()
Regards,
-Gonglei
next prev parent reply other threads:[~2015-02-12 2:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:50 [Qemu-trivial] [PATCH v2] spice: fix memory leak Gerd Hoffmann
2015-02-11 16:50 ` [Qemu-devel] " Gerd Hoffmann
2015-02-12 2:14 ` Gonglei [this message]
2015-02-12 2:14 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC0C9B.40505@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.